Enabling `gn check` on webrtc/test

Enabling `gn check` on webrtc/test

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2911203002
Cr-Commit-Position: refs/heads/master@{#18372}
Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2

[mbonadei, 2017-05-30 13:55:48]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[mbonadei, 2017-05-30 13:55:49]

In PS#4 we ran all the common trybots.

PS#5 and PS#6 were broken by the absolute path issue and
by an error in the BUILD.gn file.

Another step toward a build that is able to track all the
correct dependencies. :)

[kjellander_webrtc, 2017-05-30 14:17:35]

lgtm with a question

https://codereview.webrtc.org/2911203002/diff/60001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2911203002/diff/60001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:342: deps += [ "//webrtc/sdk:objc_common" ]
You want to avoid absolute paths now, right?

[mbonadei, 2017-05-30 14:26:31]

On 2017/05/30 14:17:35, kjellander_webrtc wrote:
> lgtm with a question
> 
> https://codereview.webrtc.org/2911203002/diff/60001/webrtc/test/BUILD.gn
> File webrtc/test/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2911203002/diff/60001/webrtc/test/BUILD.gn#newc...
> webrtc/test/BUILD.gn:342: deps += [ "//webrtc/sdk:objc_common" ]
> You want to avoid absolute paths now, right?

Yep, in PS#6 after the rebase it is relative. PS#4 was created while I was
working on the CL to make paths relative.

[kjellander_webrtc, 2017-05-30 14:28:46]

On 2017/05/30 14:26:31, mbonadei wrote:
> On 2017/05/30 14:17:35, kjellander_webrtc wrote:
> > lgtm with a question
> > 
> > https://codereview.webrtc.org/2911203002/diff/60001/webrtc/test/BUILD.gn
> > File webrtc/test/BUILD.gn (right):
> > 
> >
>
https://codereview.webrtc.org/2911203002/diff/60001/webrtc/test/BUILD.gn#newc...
> > webrtc/test/BUILD.gn:342: deps += [ "//webrtc/sdk:objc_common" ]
> > You want to avoid absolute paths now, right?
> 
> Yep, in PS#6 after the rebase it is relative. PS#4 was created while I was
> working on the CL to make paths relative.

Ah, I forgot I was looking at an inter-patch set diff.

[mbonadei, 2017-06-01 11:05:10]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-06-01 11:05:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2911203002/#ps160001 (title:
"re-adding .gn change after trybots")

[commit-bot: I haz the power, 2017-06-01 11:05:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-01 11:07:12]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1496315110356820,
"parent_rev": "d76b7b294a9c36e1f2f827913452842fdcaa62cf", "commit_rev":
"db5bb404b0f42a7c0a43f882b34ba1325d8cbae2"}

[commit-bot: I haz the power, 2017-06-01 11:07:18]

Description was changed from

==========
Enabling `gn check` on webrtc/test

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Enabling `gn check` on webrtc/test

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2911203002
Cr-Commit-Position: refs/heads/master@{#18372}
Committed:
https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b...
==========

[commit-bot: I haz the power, 2017-06-01 11:07:19]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b...

[mbonadei, 2017-06-01 11:25:32]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.webrtc.org/2920763002/ by mbonadei@webrtc.org.

The reason for reverting is: ERROR at
//webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header
from here.
#include "webrtc/base/checks.h"
          ^-------------------
The target:
  //webrtc/test:fileutils_unittests
is including a file from the target:
  //webrtc/base:rtc_base_approved

It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.

Dependency chain (there may also be others):
  //webrtc/test:fileutils_unittests -->
  //webrtc/test:fileutils --[private]-->
  //webrtc/base:rtc_base_approved
.