Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2919803002: Make error resilience configurable through VideoCodecVP9 resilience setting. (Closed)

Created:
3 years, 6 months ago by åsapersson
Modified:
3 years, 6 months ago
Reviewers:
brandtr, mflodman1, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make error resilience configurable through VideoCodecVP9 resilience setting (removes hard coded value in vp9_impl.cc). Make resilience configurable in video processor integration tests. BUG=webrtc:6783 Review-Url: https://codereview.webrtc.org/2919803002 Cr-Commit-Position: refs/heads/master@{#18493} Committed: https://chromium.googlesource.com/external/webrtc/+/15dcb38e5ff6666f93ed721743be3eeb59040471

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -24 lines) Patch
M webrtc/common_types.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 6 chunks +11 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 15 chunks +19 lines, -15 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (15 generated)
åsapersson
3 years, 6 months ago (2017-06-02 08:52:30 UTC) #5
brandtr
lgtm
3 years, 6 months ago (2017-06-02 13:52:34 UTC) #8
åsapersson
Magnus, can you have a look at webrtc/common_types.h
3 years, 6 months ago (2017-06-02 14:21:17 UTC) #10
mflodman1
LGTM
3 years, 6 months ago (2017-06-08 06:42:44 UTC) #12
mflodman
And LGTM with the right account.
3 years, 6 months ago (2017-06-08 08:40:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2919803002/20001
3 years, 6 months ago (2017-06-08 09:53:08 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 09:55:14 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/15dcb38e5ff6666f93ed72174...

Powered by Google App Engine
This is Rietveld 408576698