Make error resilience configurable through VideoCodecVP9 resilience setting.

webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h"
 
 namespace webrtc {
 namespace test {
 
 namespace {
 
 // In these correctness tests, we only consider SW codecs.
 const bool kHwCodec = false;
 
 // Only allow encoder/decoder to use single core, for predictability.
 const bool kUseSingleCore = true;
 
+// Default codec setting is on.
+const bool kResilienceOn = true;
+
 }  // namespace
 
 #if defined(WEBRTC_VIDEOPROCESSOR_H264_TESTS)
 
 // H264: Run with no packet loss and fixed bitrate. Quality should be very high.
 // Note(hbos): The PacketManipulatorImpl code used to simulate packet loss in
 // these unittests appears to drop "packets" in a way that is not compatible
 // with H264. Therefore ProcessXPercentPacketLossH264, X != 0, unittests have
 // not been added.
 TEST_F(VideoProcessorIntegrationTest, Process0PercentPacketLossH264) {
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 500, 30, 0);
   rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1;
   rate_profile.num_frames = kNumFramesShort;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecH264, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, false, true, false);
+                 0.0f, -1, 1, false, false, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 35.0, 25.0, 0.93, 0.70);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[1];
   SetRateControlThresholds(rc_thresholds, 0, 2, 60, 20, 10, 20, 0, 1);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
 #endif  // defined(WEBRTC_VIDEOPROCESSOR_H264_TESTS)
 
 // Fails on iOS. See webrtc:4755.
 #if !defined(WEBRTC_IOS)
 
 #if !defined(RTC_DISABLE_VP9)
 // VP9: Run with no packet loss and fixed bitrate. Quality should be very high.
 // One key frame (first frame only) in sequence. Setting |key_frame_interval|
 // to -1 below means no periodic key frames in test.
 TEST_F(VideoProcessorIntegrationTest, Process0PercentPacketLossVP9) {
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 500, 30, 0);
   rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1;
   rate_profile.num_frames = kNumFramesShort;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP9, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, false, true, false);
+                 0.0f, -1, 1, false, false, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 37.0, 36.0, 0.93, 0.92);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[1];
   SetRateControlThresholds(rc_thresholds, 0, 0, 40, 20, 10, 20, 0, 1);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
 // VP9: Run with 5% packet loss and fixed bitrate. Quality should be a bit
 // lower. One key frame (first frame only) in sequence.
 TEST_F(VideoProcessorIntegrationTest, Process5PercentPacketLossVP9) {
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 500, 30, 0);
   rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1;
   rate_profile.num_frames = kNumFramesShort;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP9, kHwCodec, kUseSingleCore,
-                 0.05f, -1, 1, false, false, true, false);
+                 0.05f, -1, 1, false, false, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 17.0, 14.0, 0.45, 0.36);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[1];
   SetRateControlThresholds(rc_thresholds, 0, 0, 40, 20, 10, 20, 0, 1);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
 // VP9: Run with no packet loss, with varying bitrate (3 rate updates):
 // low to high to medium. Check that quality and encoder response to the new
 // target rate/per-frame bandwidth (for each rate update) is within limits.
 // One key frame (first frame only) in sequence.
 TEST_F(VideoProcessorIntegrationTest, ProcessNoLossChangeBitRateVP9) {
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 200, 30, 0);
   SetRateProfile(&rate_profile, 1, 700, 30, 100);
   SetRateProfile(&rate_profile, 2, 500, 30, 200);
   rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1;
   rate_profile.num_frames = kNumFramesLong;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP9, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, false, true, false);
+                 0.0f, -1, 1, false, false, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 35.5, 30.0, 0.90, 0.85);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[3];
   SetRateControlThresholds(rc_thresholds, 0, 0, 30, 20, 20, 35, 0, 1);
   SetRateControlThresholds(rc_thresholds, 1, 2, 0, 20, 20, 60, 0, 0);
   SetRateControlThresholds(rc_thresholds, 2, 0, 0, 25, 20, 40, 0, 0);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
@@ skipping 12 matching lines @@
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 100, 24, 0);
   SetRateProfile(&rate_profile, 1, 100, 15, 100);
   SetRateProfile(&rate_profile, 2, 100, 10, 200);
   rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1;
   rate_profile.num_frames = kNumFramesLong;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP9, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, false, true, false);
+                 0.0f, -1, 1, false, false, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 31.5, 18.0, 0.80, 0.43);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[3];
   SetRateControlThresholds(rc_thresholds, 0, 45, 50, 95, 15, 45, 0, 1);
   SetRateControlThresholds(rc_thresholds, 1, 20, 0, 50, 10, 30, 0, 0);
   SetRateControlThresholds(rc_thresholds, 2, 5, 0, 30, 5, 25, 0, 0);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
 // VP9: Run with no packet loss and denoiser on. One key frame (first frame).
 TEST_F(VideoProcessorIntegrationTest, ProcessNoLossDenoiserOnVP9) {
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 500, 30, 0);
   rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1;
   rate_profile.num_frames = kNumFramesShort;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP9, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, true, true, false);
+                 0.0f, -1, 1, false, true, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 36.8, 35.8, 0.92, 0.91);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[1];
   SetRateControlThresholds(rc_thresholds, 0, 0, 40, 20, 10, 20, 0, 1);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
 // Run with no packet loss, at low bitrate.
 // spatial_resize is on, for this low bitrate expect one resize in sequence.
 // Resize happens on delta frame. Expect only one key frame (first frame).
 TEST_F(VideoProcessorIntegrationTest,
        DISABLED_ProcessNoLossSpatialResizeFrameDropVP9) {
   config_.networking_config.packet_loss_probability = 0;
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 50, 30, 0);
   rate_profile.frame_index_rate_update[1] = kNumFramesLong + 1;
   rate_profile.num_frames = kNumFramesLong;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP9, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, false, true, true);
+                 0.0f, -1, 1, false, false, true, true, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 24.0, 13.0, 0.65, 0.37);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[1];
   SetRateControlThresholds(rc_thresholds, 0, 228, 70, 160, 15, 80, 1, 1);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
 // TODO(marpan): Add temporal layer test for VP9, once changes are in
 // vp9 wrapper for this.
 
 #endif  // !defined(RTC_DISABLE_VP9)
 
 // VP8: Run with no packet loss and fixed bitrate. Quality should be very high.
 // One key frame (first frame only) in sequence. Setting |key_frame_interval|
 // to -1 below means no periodic key frames in test.
 TEST_F(VideoProcessorIntegrationTest, ProcessZeroPacketLoss) {
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 500, 30, 0);
   rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1;
   rate_profile.num_frames = kNumFramesShort;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP8, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, true, true, false);
+                 0.0f, -1, 1, false, true, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 34.95, 33.0, 0.90, 0.89);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[1];
   SetRateControlThresholds(rc_thresholds, 0, 0, 40, 20, 10, 15, 0, 1);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
 // VP8: Run with 5% packet loss and fixed bitrate. Quality should be a bit
 // lower. One key frame (first frame only) in sequence.
 TEST_F(VideoProcessorIntegrationTest, Process5PercentPacketLoss) {
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 500, 30, 0);
   rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1;
   rate_profile.num_frames = kNumFramesShort;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP8, kHwCodec, kUseSingleCore,
-                 0.05f, -1, 1, false, true, true, false);
+                 0.05f, -1, 1, false, true, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 20.0, 16.0, 0.60, 0.40);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[1];
   SetRateControlThresholds(rc_thresholds, 0, 0, 40, 20, 10, 15, 0, 1);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
 // VP8: Run with 10% packet loss and fixed bitrate. Quality should be lower.
 // One key frame (first frame only) in sequence.
 TEST_F(VideoProcessorIntegrationTest, Process10PercentPacketLoss) {
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 500, 30, 0);
   rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1;
   rate_profile.num_frames = kNumFramesShort;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP8, kHwCodec, kUseSingleCore,
-                 0.1f, -1, 1, false, true, true, false);
+                 0.1f, -1, 1, false, true, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 19.0, 16.0, 0.50, 0.35);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[1];
   SetRateControlThresholds(rc_thresholds, 0, 0, 40, 20, 10, 15, 0, 1);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
 // This test is identical to VideoProcessorIntegrationTest.ProcessZeroPacketLoss
 // except that |batch_mode| is turned on. The main point of this test is to see
 // that the reported stats are not wildly varying between batch mode and the
 // regular online mode.
 TEST_F(VideoProcessorIntegrationTest, ProcessInBatchMode) {
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 500, 30, 0);
   rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1;
   rate_profile.num_frames = kNumFramesShort;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP8, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, true, true, false, 352, 288, "foreman_cif",
-                 false /* verbose_logging */, true /* batch_mode */);
+                 0.0f, -1, 1, false, true, true, false, kResilienceOn, 352, 288,
+                 "foreman_cif", false /* verbose_logging */,
+                 true /* batch_mode */);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 34.95, 33.0, 0.90, 0.89);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[1];
   SetRateControlThresholds(rc_thresholds, 0, 0, 40, 20, 10, 15, 0, 1);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 
@@ skipping 23 matching lines @@
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 200, 30, 0);
   SetRateProfile(&rate_profile, 1, 800, 30, 100);
   SetRateProfile(&rate_profile, 2, 500, 30, 200);
   rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1;
   rate_profile.num_frames = kNumFramesLong;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP8, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, true, true, false);
+                 0.0f, -1, 1, false, true, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 34.0, 32.0, 0.85, 0.80);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[3];
   SetRateControlThresholds(rc_thresholds, 0, 0, 45, 20, 10, 15, 0, 1);
   SetRateControlThresholds(rc_thresholds, 1, 0, 0, 25, 20, 10, 0, 0);
   SetRateControlThresholds(rc_thresholds, 2, 0, 0, 25, 15, 10, 0, 0);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
@@ skipping 20 matching lines @@
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 80, 24, 0);
   SetRateProfile(&rate_profile, 1, 80, 15, 100);
   SetRateProfile(&rate_profile, 2, 80, 10, 200);
   rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1;
   rate_profile.num_frames = kNumFramesLong;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP8, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 1, false, true, true, false);
+                 0.0f, -1, 1, false, true, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 31.0, 22.0, 0.80, 0.65);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[3];
   SetRateControlThresholds(rc_thresholds, 0, 40, 20, 75, 15, 60, 0, 1);
   SetRateControlThresholds(rc_thresholds, 1, 10, 0, 25, 10, 35, 0, 0);
   SetRateControlThresholds(rc_thresholds, 2, 0, 0, 20, 10, 15, 0, 0);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
@@ skipping 15 matching lines @@
   config_.networking_config.packet_loss_probability = 0;
   // Bit rate and frame rate profile.
   RateProfile rate_profile;
   SetRateProfile(&rate_profile, 0, 200, 30, 0);
   SetRateProfile(&rate_profile, 1, 400, 30, 150);
   rate_profile.frame_index_rate_update[2] = kNumFramesLong + 1;
   rate_profile.num_frames = kNumFramesLong;
   // Codec/network settings.
   CodecParams process_settings;
   SetCodecParams(&process_settings, kVideoCodecVP8, kHwCodec, kUseSingleCore,
-                 0.0f, -1, 3, false, true, true, false);
+                 0.0f, -1, 3, false, true, true, false, kResilienceOn);
   // Thresholds for expected quality.
   QualityThresholds quality_thresholds;
   SetQualityThresholds(&quality_thresholds, 32.5, 30.0, 0.85, 0.80);
   // Thresholds for rate control.
   RateControlThresholds rc_thresholds[2];
   SetRateControlThresholds(rc_thresholds, 0, 0, 20, 30, 10, 10, 0, 1);
   SetRateControlThresholds(rc_thresholds, 1, 0, 0, 30, 15, 10, 0, 0);
   ProcessFramesAndVerify(quality_thresholds, rate_profile, process_settings,
                          rc_thresholds, nullptr /* visualization_params */);
 }
 }  // namespace test
 }  // namespace webrtc