Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2917223002: Merge to M59: Fixing SignalSentPacket for TCP connections. (Closed)

Created:
3 years, 6 months ago by Taylor Brandstetter
Modified:
3 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/branch-heads/59
Project:
webrtc
Visibility:
Public.

Description

Merge to M59: Fixing SignalSentPacket for TCP connections. The signal was only being hooked up for incoming connections, not outgoing connections. As a result, the bandwidth estimator didn't know when packets were sent and couldn't calculate delays. BUG=webrtc:7509 TBR=pthatcher@webrtc.org NOTRY=True NOPRESUBMIT=True Original Review-Url: https://codereview.webrtc.org/2834083002 Original Cr-Commit-Position: refs/heads/master@{#17817} (cherry picked from commit 06878297942a3d632dce62df18b2fe0c32cbd853) Review-Url: https://codereview.webrtc.org/2917223002 Cr-Commit-Position: refs/branch-heads/59@{#16} Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/38ffd9a17b16c18eb00e2f86f077d64bc14388b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M webrtc/p2p/base/tcpport.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/p2p/base/tcpport_unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Taylor Brandstetter
PTAL; just merging to M59. Didn't have any patch conflicts.
3 years, 6 months ago (2017-06-02 21:51:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2917223002/1
3 years, 6 months ago (2017-06-02 21:51:34 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 21:51:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/38ffd9a17b16c18eb00e2f86f...

Powered by Google App Engine
This is Rietveld 408576698