Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2834083002: Fixing SignalSentPacket for TCP connections. (Closed)

Created:
3 years, 8 months ago by Taylor Brandstetter
Modified:
3 years, 8 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing SignalSentPacket for TCP connections. The signal was only being hooked up for incoming connections, not outgoing connections. As a result, the bandwidth estimator didn't know when packets were sent and couldn't calculate delays. BUG=webrtc:7509 Review-Url: https://codereview.webrtc.org/2834083002 Cr-Commit-Position: refs/heads/master@{#17817} Committed: https://chromium.googlesource.com/external/webrtc/+/06878297942a3d632dce62df18b2fe0c32cbd853

Patch Set 1 #

Patch Set 2 : Don't crash if socket wasn't created successfully. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M webrtc/p2p/base/tcpport.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/p2p/base/tcpport_unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Taylor Brandstetter
PTAL Peter
3 years, 8 months ago (2017-04-21 14:08:27 UTC) #2
pthatcher1
lgtm
3 years, 8 months ago (2017-04-21 15:19:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2834083002/1
3 years, 8 months ago (2017-04-21 17:44:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/24066)
3 years, 8 months ago (2017-04-21 17:52:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2834083002/20001
3 years, 8 months ago (2017-04-21 20:55:19 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 21:22:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/06878297942a3d632dce62df1...

Powered by Google App Engine
This is Rietveld 408576698