Issue 2916433003: Check H264 NALUs for frametype and insert SPS/PPS packets into the PacketBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2916433003: Check H264 NALUs for frametype and insert SPS/PPS packets into the PacketBuffer. (Closed)

Created:
3 years, 6 months ago by philipel

Modified:
3 years, 6 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman

Target Ref:
refs/branch-heads/59

Project:
webrtc

Visibility:
Public.

Check H264 NALUs for frametype and insert SPS/PPS packets into the PacketBuffer. BUG=chromium:719095 Review-Url: https://codereview.webrtc.org/2889163003 Cr-Original-Commit-Position: refs/heads/master@{#18214} Review-Url: https://codereview.webrtc.org/2916433003 . Cr-Commit-Position: refs/branch-heads/59@{#14} Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/b9ca68003f9dd88241dd2022dc9c077b91bd2ea2

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -33 lines)			Patch
M	webrtc/modules/video_coding/frame_object.cc	View	2 chunks	+27 lines, -1 line	0 comments	Download
M	webrtc/modules/video_coding/h264_sps_pps_tracker.cc	View	2 chunks	+19 lines, -12 lines	0 comments	Download
M	webrtc/modules/video_coding/h264_sps_pps_tracker_unittest.cc	View	2 chunks	+20 lines, -20 lines	0 comments	Download

Total messages: 2 (1 generated)

philipel

3 years, 6 months ago (2017-05-30 21:12:25 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b9ca68003f9dd88241dd2022dc9c077b91bd2ea2.