Check H264 NALUs for frametype and insert SPS/PPS packets into the PacketBuffer.

Check H264 NALUs for frametype and insert SPS/PPS packets into the PacketBuffer.

BUG=chromium:719095
Review-Url: https://codereview.webrtc.org/2889163003
Cr-Commit-Position: refs/heads/master@{#18214}
Committed: https://chromium.googlesource.com/external/webrtc/+/e87c87651f36650e76827671c4ec2a5c436ef5a9

[philipel, 2017-05-18 15:34:33]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2017-05-18 15:52:27]

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/frame_object.cc (right):

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_object.cc:82: if (header.nalus[i].type == 5) {
Use a named constant for this. I think we already have it defined somewhere

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/h...
File webrtc/modules/video_coding/h264_sps_pps_tracker.cc (right):

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/h...
webrtc/modules/video_coding/h264_sps_pps_tracker.cc:42: bool append_sps_pps =
codec_header.nalus_length == 0 ? true : false;
Remove ?true:false. You already get a book from ==

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/h...
webrtc/modules/video_coding/h264_sps_pps_tracker.cc:107: packet->sizeBytes = 0;
Comment on why these are set to nullptr/0

[philipel, 2017-05-19 09:28:06]

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/frame_object.cc (right):

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_object.cc:82: if (header.nalus[i].type == 5) {
On 2017/05/18 15:52:26, stefan-webrtc wrote:
> Use a named constant for this. I think we already have it defined somewhere

Done.

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/h...
File webrtc/modules/video_coding/h264_sps_pps_tracker.cc (right):

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/h...
webrtc/modules/video_coding/h264_sps_pps_tracker.cc:42: bool append_sps_pps =
codec_header.nalus_length == 0 ? true : false;
On 2017/05/18 15:52:26, stefan-webrtc wrote:
> Remove ?true:false. You already get a book from ==

Done.

https://codereview.webrtc.org/2889163003/diff/1/webrtc/modules/video_coding/h...
webrtc/modules/video_coding/h264_sps_pps_tracker.cc:107: packet->sizeBytes = 0;
On 2017/05/18 15:52:26, stefan-webrtc wrote:
> Comment on why these are set to nullptr/0

Done.

[stefan-webrtc, 2017-05-19 10:30:40]

https://codereview.webrtc.org/2889163003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/h264_sps_pps_tracker.cc (right):

https://codereview.webrtc.org/2889163003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/h264_sps_pps_tracker.cc:110: // buffer, and this
function copies (and fix) the bitstream of the packet
"and fixes"

https://codereview.webrtc.org/2889163003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/h264_sps_pps_tracker.cc:115: // doesn't actually
need to contain any bitstream data.
Is this the right way of doing it? Isn't it better to keep the sps/pps data as
is and insert it the regular way, and perhaps also append it to the next idr?

[stefan-webrtc, 2017-05-19 12:46:05]

lgtm after offline discussion.

[philipel, 2017-05-19 13:05:28]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-05-19 13:05:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-19 13:38:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495199128917540,
"parent_rev": "bbbad6da7e7ba0ab8a0e2645213db80ba2445cbe", "commit_rev":
"e87c87651f36650e76827671c4ec2a5c436ef5a9"}

[commit-bot: I haz the power, 2017-05-19 13:38:54]

Description was changed from

==========
Check H264 NALUs for frametype and insert SPS/PPS packets into the PacketBuffer.

BUG=chromium:719095
==========

to

==========
Check H264 NALUs for frametype and insert SPS/PPS packets into the PacketBuffer.

BUG=chromium:719095

Review-Url: https://codereview.webrtc.org/2889163003
Cr-Commit-Position: refs/heads/master@{#18214}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e87c87651f36650e76827671c...
==========

[commit-bot: I haz the power, 2017-05-19 13:38:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/e87c87651f36650e76827671c...