Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2912773003: Reland of Adding backward compatibility header (Closed)

Created:
3 years, 6 months ago by mbonadei
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Adding backward compatibility header (patchset #1 id:1 of https://codereview.webrtc.org/2908143003/ ) Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Adding backward compatibility header (patchset #1 id:1 of https://codereview.webrtc.org/2909923002/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Adding backward compatibility header > > > > This header will be removed ad soon as downstream projects will be > > updated. > > > > BUG=webrtc:4867 > > NOTRY=True > > TBR=kjellander@webrtc.org > > > > Review-Url: https://codereview.webrtc.org/2909923002 > > Cr-Commit-Position: refs/heads/master@{#18306} > > Committed: https://chromium.googlesource.com/external/webrtc/+/4fa8a97cc3268de73ad021ff56aaa9bf1a566ed4 > > TBR=kjellander@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4867 > > Review-Url: https://codereview.webrtc.org/2908143003 > Cr-Commit-Position: refs/heads/master@{#18308} > Committed: https://chromium.googlesource.com/external/webrtc/+/6684fdce93ff25a837117cd7a811a6d86cbe4b20 TBR=kjellander@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2912773003 Cr-Commit-Position: refs/heads/master@{#18320} Committed: https://chromium.googlesource.com/external/webrtc/+/d7620582342bb896b766bb306135b12aefbeb12c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M webrtc/sdk/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/corevideo_frame_buffer.h View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mbonadei
Created Reland of Adding backward compatibility header
3 years, 6 months ago (2017-05-30 08:48:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2912773003/1
3 years, 6 months ago (2017-05-30 08:50:33 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 08:50:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d7620582342bb896b766bb306...

Powered by Google App Engine
This is Rietveld 408576698