Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2909923002: Adding backward compatibility header (Closed)

Created:
3 years, 6 months ago by mbonadei
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding backward compatibility header This header will be removed ad soon as downstream projects will be updated. BUG=webrtc:4867 NOTRY=True TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2909923002 Cr-Commit-Position: refs/heads/master@{#18306} Committed: https://chromium.googlesource.com/external/webrtc/+/4fa8a97cc3268de73ad021ff56aaa9bf1a566ed4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M webrtc/sdk/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/corevideo_frame_buffer.h View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
mbonadei
3 years, 6 months ago (2017-05-29 14:46:50 UTC) #2
magjed_webrtc
lgtm
3 years, 6 months ago (2017-05-29 15:02:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2909923002/1
3 years, 6 months ago (2017-05-29 15:08:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17507)
3 years, 6 months ago (2017-05-29 15:11:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2909923002/1
3 years, 6 months ago (2017-05-29 15:19:07 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/4fa8a97cc3268de73ad021ff56aaa9bf1a566ed4
3 years, 6 months ago (2017-05-29 15:21:02 UTC) #16
kjellander_webrtc
lgtm
3 years, 6 months ago (2017-05-29 15:26:29 UTC) #17
mbonadei
3 years, 6 months ago (2017-05-29 16:41:05 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2908143003/ by mbonadei@webrtc.org.

The reason for reverting is: Breaks downstream project..

Powered by Google App Engine
This is Rietveld 408576698