Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2912363002: Small cleanup of rtp_rtcp testAPI tests. (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Small cleanup of rtp_rtcp testAPI tests. Delete unused member |rtp_receiver_|, and simplify a return statement. BUG=webrtc:5565 Review-Url: https://codereview.webrtc.org/2912363002 Cr-Commit-Position: refs/heads/master@{#18354} Committed: https://chromium.googlesource.com/external/webrtc/+/be3e53960094cf430a4a81ac91b6c15d0d64c091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
nisse-webrtc
PTAL. The interesting part is the removal of a call to RtpReceiver::CreateAudioReceiver, which depends on ...
3 years, 6 months ago (2017-05-31 12:53:09 UTC) #2
danilchap
lgtm
3 years, 6 months ago (2017-05-31 14:03:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2912363002/1
3 years, 6 months ago (2017-05-31 14:15:07 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 14:35:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/be3e53960094cf430a4a81ac9...

Powered by Google App Engine
This is Rietveld 408576698