Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

Issue 2912363002: Small cleanup of rtp_rtcp testAPI tests. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
diff --git a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
index 4eac882bb0a66591e8f5b47c04a223715e643b9c..b8b67c703f5923746b2fd776a1816cafdfc4161f 100644
--- a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
+++ b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
@@ -57,11 +57,8 @@ bool LoopBackTransport::SendRtp(const uint8_t* data,
RTC_CHECK_GE(len, header.headerLength);
const size_t payload_length = len - header.headerLength;
receive_statistics_->IncomingPacket(header, len, false);
- if (!rtp_receiver_->IncomingRtpPacket(header, payload, payload_length,
- payload_specific, true)) {
- return false;
- }
- return true;
+ return rtp_receiver_->IncomingRtpPacket(header, payload, payload_length,
+ payload_specific, true);
}
bool LoopBackTransport::SendRtcp(const uint8_t* data, size_t len) {
@@ -105,12 +102,9 @@ class RtpRtcpAPITest : public ::testing::Test {
module_.reset(RtpRtcp::CreateRtpRtcp(configuration));
module_->SetSSRC(initial_ssrc);
rtp_payload_registry_.reset(new RTPPayloadRegistry());
- rtp_receiver_.reset(RtpReceiver::CreateAudioReceiver(
- &fake_clock_, NULL, NULL, rtp_payload_registry_.get()));
}
std::unique_ptr<RTPPayloadRegistry> rtp_payload_registry_;
- std::unique_ptr<RtpReceiver> rtp_receiver_;
std::unique_ptr<RtpRtcp> module_;
uint32_t test_ssrc_;
uint32_t test_timestamp_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698