Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2912113002: Ensure the RtcEventLog parser is backwards compatible (Closed)

Created:
3 years, 6 months ago by terelius
Modified:
3 years, 6 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ensure the RtcEventLog parser is backwards compatible The old video send stream configs could contain multiple SSRCs and RTX SSRCs (in case of simulcast). To ensure that the RtcEventLog parser is backwards compatible, we have to return one config for every SSRC. Also update the parsing functions for the other config types to return the config instead of passing in an output parameter. BUG=webrtc:7731 Review-Url: https://codereview.webrtc.org/2912113002 Cr-Commit-Position: refs/heads/master@{#18343} Committed: https://chromium.googlesource.com/external/webrtc/+/8fbc76542118d4a05357b87b8ed8ee8dbf3874df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -134 lines) Patch
M webrtc/logging/rtc_event_log/rtc_event_log2text.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 2 chunks +15 lines, -16 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 8 chunks +82 lines, -83 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 2 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
terelius
3 years, 6 months ago (2017-05-30 16:07:00 UTC) #6
perkj_webrtc
lgtm
3 years, 6 months ago (2017-05-30 19:09:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2912113002/1
3 years, 6 months ago (2017-05-31 09:01:22 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 09:03:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8fbc76542118d4a05357b87b8...

Powered by Google App Engine
This is Rietveld 408576698