Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log2text.cc

Issue 2912113002: Ensure the RtcEventLog parser is backwards compatible (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/rtc_event_log_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/logging/rtc_event_log/rtc_event_log2text.cc
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log2text.cc b/webrtc/logging/rtc_event_log/rtc_event_log2text.cc
index ec6681072232b1c609126f1a9aee197f73718e27..26bddf7d825390904dc28d2a1d079909408bebb8 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log2text.cc
+++ b/webrtc/logging/rtc_event_log/rtc_event_log2text.cc
@@ -352,8 +352,8 @@ int main(int argc, char* argv[]) {
if (!FLAGS_noconfig && !FLAGS_novideo && !FLAGS_noincoming &&
parsed_stream.GetEventType(i) ==
webrtc::ParsedRtcEventLog::VIDEO_RECEIVER_CONFIG_EVENT) {
- webrtc::rtclog::StreamConfig config;
- parsed_stream.GetVideoReceiveConfig(i, &config);
+ webrtc::rtclog::StreamConfig config =
+ parsed_stream.GetVideoReceiveConfig(i);
std::cout << parsed_stream.GetTimestamp(i) << "\tVIDEO_RECV_CONFIG"
<< "\tssrc=" << config.remote_ssrc
<< "\tfeedback_ssrc=" << config.local_ssrc << std::endl;
@@ -361,18 +361,20 @@ int main(int argc, char* argv[]) {
if (!FLAGS_noconfig && !FLAGS_novideo && !FLAGS_nooutgoing &&
parsed_stream.GetEventType(i) ==
webrtc::ParsedRtcEventLog::VIDEO_SENDER_CONFIG_EVENT) {
- webrtc::rtclog::StreamConfig config;
- parsed_stream.GetVideoSendConfig(i, &config);
+ std::vector<webrtc::rtclog::StreamConfig> configs =
+ parsed_stream.GetVideoSendConfig(i);
+ for (size_t j = 0; j < configs.size(); j++) {
std::cout << parsed_stream.GetTimestamp(i) << "\tVIDEO_SEND_CONFIG";
- std::cout << "\tssrcs=" << config.local_ssrc;
- std::cout << "\trtx_ssrcs=" << config.rtx_ssrc;
+ std::cout << "\tssrcs=" << configs[j].local_ssrc;
+ std::cout << "\trtx_ssrcs=" << configs[j].rtx_ssrc;
std::cout << std::endl;
+ }
}
if (!FLAGS_noconfig && !FLAGS_noaudio && !FLAGS_noincoming &&
parsed_stream.GetEventType(i) ==
webrtc::ParsedRtcEventLog::AUDIO_RECEIVER_CONFIG_EVENT) {
- webrtc::rtclog::StreamConfig config;
- parsed_stream.GetAudioReceiveConfig(i, &config);
+ webrtc::rtclog::StreamConfig config =
+ parsed_stream.GetAudioReceiveConfig(i);
std::cout << parsed_stream.GetTimestamp(i) << "\tAUDIO_RECV_CONFIG"
<< "\tssrc=" << config.remote_ssrc
<< "\tfeedback_ssrc=" << config.local_ssrc << std::endl;
@@ -380,8 +382,7 @@ int main(int argc, char* argv[]) {
if (!FLAGS_noconfig && !FLAGS_noaudio && !FLAGS_nooutgoing &&
parsed_stream.GetEventType(i) ==
webrtc::ParsedRtcEventLog::AUDIO_SENDER_CONFIG_EVENT) {
- webrtc::rtclog::StreamConfig config;
- parsed_stream.GetAudioSendConfig(i, &config);
+ webrtc::rtclog::StreamConfig config = parsed_stream.GetAudioSendConfig(i);
std::cout << parsed_stream.GetTimestamp(i) << "\tAUDIO_SEND_CONFIG"
<< "\tssrc=" << config.local_ssrc << std::endl;
}
« no previous file with comments | « no previous file | webrtc/logging/rtc_event_log/rtc_event_log_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698