Ensure the diff functions are generated in order specified in the JSON file

Ensure the diff functions are generated in order specified in the JSON file

This CL ensures that the diff functions are generated in the order that
they are specified in the JSOn input file as opposed to in the alignment
order as specified in the groups.

Diff: https://gist.github.com/ffa56bb0036497ad3a104a1e2f79d0bf/revisions

BUG=710938
Review-Url: https://codereview.chromium.org/2911593002
Cr-Commit-Position: refs/heads/master@{#474935}
Committed: https://chromium.googlesource.com/chromium/src/+/3b3e6c62644f6bf31d924c3f9256c105489a7f5d

[nainar, 2017-05-26 01:14:29]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 01:15:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-26 01:16:01]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[nainar, 2017-05-26 01:16:02]

shend@, 

PTAL? Thanks!

https://codereview.chromium.org/2911593002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2911593002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:214: for
entry in fields_to_diff:
Could make one unified list of fields and field_dependencies but that makes the
code ugly cause you have to differentiate between expressions and predicates.

[shend, 2017-05-26 01:34:30]

lgtm

https://codereview.chromium.org/2911593002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2911593002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:214: for
entry in fields_to_diff:
On 2017/05/26 at 01:16:02, nainar wrote:
> Could make one unified list of fields and field_dependencies but that makes
the code ugly cause you have to differentiate between expressions and
predicates.

Agreed.

https://codereview.chromium.org/2911593002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:216: if (not
field.is_inherited_flag) and (entry == field.property_name):
nit: don't need brackets around conditions.

[nainar, 2017-05-26 01:52:26]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 01:52:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-26 01:54:00]

The CQ bit was unchecked by nainar@chromium.org

[nainar, 2017-05-26 01:54:03]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-05-26 01:54:03]

The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2911593002/#ps20001
(title: "shend@ suggestions")

[nainar, 2017-05-26 01:54:28]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 01:55:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:54:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 05:54:39]

Dry run: This issue passed the CQ dry run.

[nainar1, 2017-05-26 05:58:27]

The CQ bit was checked by nainar@google.com

[commit-bot: I haz the power, 2017-05-26 05:59:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 06:04:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495778307822570,
"parent_rev": "d483fb7716e28b377c70c26c1bf1e3695aa1d8c9", "commit_rev":
"3b3e6c62644f6bf31d924c3f9256c105489a7f5d"}

[commit-bot: I haz the power, 2017-05-26 06:04:57]

Description was changed from

==========
Ensure the diff functions are generated in order specified in the JSON file

This CL ensures that the diff functions are generated in the order that
they are specified in the JSOn input file as opposed to in the alignment
order as specified in the groups.

Diff: https://gist.github.com/ffa56bb0036497ad3a104a1e2f79d0bf/revisions

BUG=710938
==========

to

==========
Ensure the diff functions are generated in order specified in the JSON file

This CL ensures that the diff functions are generated in the order that
they are specified in the JSOn input file as opposed to in the alignment
order as specified in the groups.

Diff: https://gist.github.com/ffa56bb0036497ad3a104a1e2f79d0bf/revisions

BUG=710938

Review-Url: https://codereview.chromium.org/2911593002
Cr-Commit-Position: refs/heads/master@{#474935}
Committed:
https://chromium.googlesource.com/chromium/src/+/3b3e6c62644f6bf31d924c3f9256...
==========

[commit-bot: I haz the power, 2017-05-26 06:04:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3b3e6c62644f6bf31d924c3f9256...