Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2911593002: Ensure the diff functions are generated in order specified in the JSON file (Closed)
Patch Set: shend@ suggestions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py
diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
index 787cee19849787eef9a24045da25f01337c15b4e..910b080d24a09ff50ae54e3107f86cf73e9dedfc 100755
--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
@@ -211,16 +211,18 @@ def _create_diff_groups(fields_to_diff, methods_to_diff, predicates_to_test, roo
for subgroup in root_group.subgroups:
if any(field.property_name in (fields_to_diff + field_dependencies) for field in subgroup.all_fields):
diff_group.subgroups.append(_create_diff_groups(fields_to_diff, methods_to_diff, predicates_to_test, subgroup))
- for field in root_group.fields:
- if not field.is_inherited_flag:
- if field.property_name in fields_to_diff:
+ for entry in fields_to_diff:
+ for field in root_group.fields:
+ if not field.is_inherited_flag and entry == field.property_name:
diff_group.expressions.append(field.getter_expression)
- for entry in methods_to_diff:
- if field.property_name in entry['field_dependencies']:
- diff_group.expressions.append(entry['method'])
- for entry in predicates_to_test:
- if field.property_name in entry['field_dependencies']:
- diff_group.predicates.append(entry['predicate'])
+ for entry in methods_to_diff:
+ for field in root_group.fields:
+ if not field.is_inherited_flag and field.property_name in entry['field_dependencies']:
+ diff_group.expressions.append(entry['method'])
+ for entry in predicates_to_test:
+ for field in root_group.fields:
+ if not field.is_inherited_flag and field.property_name in entry['field_dependencies']:
+ diff_group.predicates.append(entry['predicate'])
return diff_group
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698