Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2910633002: Revert of Activate 'offload debug dump recordings from audio thread to TaskQueue'. (Closed)

Created:
3 years, 7 months ago by aleloi
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, danilchap
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Activate 'offload debug dump recordings from audio thread to TaskQueue'. (patchset #1 id:1 of https://codereview.webrtc.org/2903153005/ ) Reason for revert: Reverting again: internal project issues were apparently not completely fixed. Original issue's description: > Reland of Activate 'offload debug dump recordings from audio thread to TaskQueue'. (patchset #1 id:1 of https://codereview.webrtc.org/2904893002/ ) > > Reason for revert: > Revert the revert now that internal projects are updated. > > Original issue's description: > > Revert of Activate 'offload debug dump recordings from audio thread to TaskQueue'. (patchset #4 id:160001 of https://codereview.webrtc.org/2896813002/ ) > > > > Reason for revert: > > Breaks internal project. > > > > Original issue's description: > > > Activate 'offload debug dump recordings from audio thread to TaskQueue'. > > > > > > A low priority task queue is added to WebRTCVoiceEngine. The > > > start/stop debug calls make file logging happen on the task queue. > > > > > > In a dependent CL (https://codereview.webrtc.org/2888303003), the task queue is moved to PeerConnectionFactory, > > > so that it can be shared for low priority tasks between different > > > subcomponents. It will require some changes to MediaEngine, > > > CompositeMediaEngine, WebRTCVoiceEngine, and changes in internal > > > projects. > > > > > > A task queue must be created and destroyed from the same thread. With > > > this CL that will be the worker thread, which creates and destroys > > > WebRTCVoiceEngine. With the dependent CL, it will probably change to > > > the signaling thread. > > > > > > NOTRY=True # tests just passed > > > > > > BUG=webrtc:7404 > > > > > > Review-Url: https://codereview.webrtc.org/2896813002 > > > Cr-Commit-Position: refs/heads/master@{#18252} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/c61bf947b4ac31f3500858ffcae6fee39d799930 > > > > TBR=solenberg@webrtc.org,tommi@webrtc.org,perkj@webrtc.org,danilchap@webrtc.org,tommi@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:7404 > > > > Review-Url: https://codereview.webrtc.org/2904893002 > > Cr-Commit-Position: refs/heads/master@{#18255} > > Committed: https://chromium.googlesource.com/external/webrtc/+/be68b72cfad0686dcd892bba1368b199a7ee16ca > > TBR=solenberg@webrtc.org,tommi@webrtc.org,perkj@webrtc.org,danilchap@webrtc.org,tommi@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7404 > > Review-Url: https://codereview.webrtc.org/2903153005 > Cr-Commit-Position: refs/heads/master@{#18270} > Committed: https://chromium.googlesource.com/external/webrtc/+/d2303a2338106feab684860f1c133877b46bdd4f TBR=solenberg@webrtc.org,tommi@webrtc.org,perkj@webrtc.org,danilchap@webrtc.org,tommi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7404 Review-Url: https://codereview.webrtc.org/2910633002 Cr-Commit-Position: refs/heads/master@{#18272} Committed: https://chromium.googlesource.com/external/webrtc/+/fe9ecb07ea8254d8a09605f25203a4d045b3ffee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M webrtc/media/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 3 chunks +31 lines, -15 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aleloi
Created Revert of Activate 'offload debug dump recordings from audio thread to TaskQueue'.
3 years, 7 months ago (2017-05-26 12:46:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2910633002/1
3 years, 7 months ago (2017-05-26 12:46:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/fe9ecb07ea8254d8a09605f25203a4d045b3ffee
3 years, 7 months ago (2017-05-26 12:46:40 UTC) #6
mbonadei
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2910643002/ by mbonadei@webrtc.org. ...
3 years, 7 months ago (2017-05-26 14:18:47 UTC) #7
aleloi
3 years, 6 months ago (2017-05-29 09:29:53 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2904423002/ by aleloi@webrtc.org.

The reason for reverting is: Revert of revert of revert of revert of
'Activating..'. Or "reland of reland of 'Activate..'".

*Now* the internal projects are fixed and the fix is verified. .

Powered by Google App Engine
This is Rietveld 408576698