Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2888303003: Work-in-progress upload to add worker task queue to PC factory.

Created:
3 years, 7 months ago by aleloi
Modified:
3 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Work-in-progress upload to add worker task queue to PC factory. BUG=will add later.

Patch Set 1 #

Patch Set 2 : Add strict mock<audio processing> expectation. #

Patch Set 3 : Another EXPECT_CALL on strict apm mocks. #

Patch Set 4 : Made TQ actually low prio, creates backup TQ in CompositeMediaEngine. #

Patch Set 5 : Rebase on 'activate_aec_dump_lite' #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -42 lines) Patch
M webrtc/media/base/fakemediaengine.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/media/base/mediaengine.h View 1 2 3 4 chunks +22 lines, -3 lines 0 comments Download
M webrtc/media/engine/nullwebrtcvideoengine_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcmediaengine.h View 2 chunks +15 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcmediaengine.cc View 1 2 3 7 chunks +32 lines, -10 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 2 3 4 4 chunks +12 lines, -7 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 2 3 4 5 8 chunks +11 lines, -10 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/pc/peerconnectionfactory.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2896813002 Patch 20001

Messages

Total messages: 16 (16 generated)
aleloi
The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run
3 years, 7 months ago (2017-05-18 12:10:51 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2888303003/1
3 years, 7 months ago (2017-05-18 12:10:59 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-18 12:24:49 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/25752)
3 years, 7 months ago (2017-05-18 12:24:50 UTC) #4
aleloi
The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run
3 years, 7 months ago (2017-05-18 12:29:58 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2888303003/20001
3 years, 7 months ago (2017-05-18 12:30:08 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-18 12:37:36 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/24808)
3 years, 7 months ago (2017-05-18 12:37:37 UTC) #8
aleloi
The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run
3 years, 7 months ago (2017-05-18 12:42:42 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2888303003/40001
3 years, 7 months ago (2017-05-18 12:42:46 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-18 13:32:54 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/24200)
3 years, 7 months ago (2017-05-18 13:32:55 UTC) #12
aleloi
The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run
3 years, 7 months ago (2017-05-18 13:53:40 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2888303003/60001
3 years, 7 months ago (2017-05-18 13:53:44 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-18 14:01:53 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 14:01:54 UTC) #16 
Dry run: Try jobs failed on following builders:
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

Powered by Google App Engine
This is Rietveld 408576698