third_party/WebKit/Source/modules/webaudio/AudioNode.cpp - Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

index 2fc46b56f2b9ac97dab19bec5b149f7c8b68eb13..657228a8b6f86e9945b33edb377c80ac6fc581a7 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

@@ -550,9 +550,10 @@ void AudioNode::Dispose() {

#endif

BaseAudioContext::AutoLocker locker(context());

Handler().Dispose();

- if (context()->ContextState() == BaseAudioContext::kRunning)

+ if (context()->ContextState() == BaseAudioContext::kRunning) {

context()->GetDeferredTaskHandler().AddRenderingOrphanHandler(

- handler_.Release());

+ std::move(handler_));

+ }

}

void AudioNode::SetHandler(PassRefPtr<AudioHandler> handler) {