Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2907463003: Remove window.status plumbing, it's unused and the spec says it's a dummy (Closed)

Created:
3 years, 7 months ago by Nate Chapin
Modified:
3 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Peter Beverloo, nasko+codewatch_chromium.org, jam, blink-reviews-api_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, kinuko+watch, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove window.status plumbing, it's unused and the spec says it's a dummy BUG= Review-Url: https://codereview.chromium.org/2907463003 Cr-Commit-Position: refs/heads/master@{#474943} Committed: https://chromium.googlesource.com/chromium/src/+/dc6e63b94611ee34d8dc8d09247462d5b0bee8eb

Patch Set 1 #

Patch Set 2 : Drop accidental change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -139 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/test_runner/layout_test_runtime_flags.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/test_runner/layout_test_runtime_flags.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/test_runner/test_runner.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/shell/test_runner/test_runner.cc View 5 chunks +0 lines, -19 lines 0 comments Download
M content/shell/test_runner/web_view_test_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/test_runner/web_view_test_client.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/shell/test_runner/web_view_test_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/assign-to-window-status.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/assign-to-window-status-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Nate Chapin
Random cleanup :)
3 years, 7 months ago (2017-05-26 00:52:23 UTC) #8
kinuko
lgtm!
3 years, 7 months ago (2017-05-26 05:09:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907463003/20001
3 years, 7 months ago (2017-05-26 05:11:49 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 06:39:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc6e63b94611ee34d8dc8d092474...

Powered by Google App Engine
This is Rietveld 408576698