Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: content/shell/test_runner/test_runner.cc

Issue 2907463003: Remove window.status plumbing, it's unused and the spec says it's a dummy (Closed)
Patch Set: Drop accidental change Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/test_runner/test_runner.h ('k') | content/shell/test_runner/web_view_test_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/test_runner/test_runner.cc
diff --git a/content/shell/test_runner/test_runner.cc b/content/shell/test_runner/test_runner.cc
index f842984e2339b35d5d7459534d4bf4293092fde3..91c408b94336265131681d1812ae3671af6314a3 100644
--- a/content/shell/test_runner/test_runner.cc
+++ b/content/shell/test_runner/test_runner.cc
@@ -155,7 +155,6 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
void DumpSpellCheckCallbacks();
void DumpTitleChanges();
void DumpUserGestureInFrameLoadCallbacks();
- void DumpWindowStatusChanges();
void EnableUseZoomForDSF(v8::Local<v8::Function> callback);
void EvaluateInWebInspector(int call_id, const std::string& script);
void EvaluateScriptInIsolatedWorld(int world_id, const std::string& script);
@@ -439,10 +438,6 @@ gin::ObjectTemplateBuilder TestRunnerBindings::GetObjectTemplateBuilder(
.SetMethod("dumpSelectionRect", &TestRunnerBindings::DumpSelectionRect)
.SetMethod("dumpSpellCheckCallbacks",
&TestRunnerBindings::DumpSpellCheckCallbacks)
-
- // Used at fast/dom/assign-to-window-status.html
- .SetMethod("dumpStatusCallbacks",
- &TestRunnerBindings::DumpWindowStatusChanges)
.SetMethod("dumpTitleChanges", &TestRunnerBindings::DumpTitleChanges)
.SetMethod("dumpUserGestureInFrameLoadCallbacks",
&TestRunnerBindings::DumpUserGestureInFrameLoadCallbacks)
@@ -1201,11 +1196,6 @@ void TestRunnerBindings::DumpPermissionClientCallbacks() {
runner_->DumpPermissionClientCallbacks();
}
-void TestRunnerBindings::DumpWindowStatusChanges() {
- if (runner_)
- runner_->DumpWindowStatusChanges();
-}
-
void TestRunnerBindings::DumpSpellCheckCallbacks() {
if (runner_)
runner_->DumpSpellCheckCallbacks();
@@ -1882,10 +1872,6 @@ void TestRunner::InitializeWebViewWithMocks(blink::WebView* web_view) {
web_view->SetCredentialManagerClient(credential_manager_client_.get());
}
-bool TestRunner::shouldDumpStatusCallbacks() const {
- return layout_test_runtime_flags_.dump_window_status_changes();
-}
-
bool TestRunner::shouldDumpSpellCheckCallbacks() const {
return layout_test_runtime_flags_.dump_spell_check_callbacks();
}
@@ -2564,11 +2550,6 @@ void TestRunner::SetDisallowedSubresourcePathSuffixes(
new MockWebDocumentSubresourceFilter(suffixes));
}
-void TestRunner::DumpWindowStatusChanges() {
- layout_test_runtime_flags_.set_dump_window_status_changes(true);
- OnLayoutTestRuntimeFlagsChanged();
-}
-
void TestRunner::DumpSpellCheckCallbacks() {
layout_test_runtime_flags_.set_dump_spell_check_callbacks(true);
OnLayoutTestRuntimeFlagsChanged();
« no previous file with comments | « content/shell/test_runner/test_runner.h ('k') | content/shell/test_runner/web_view_test_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698