Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2904703002: Add a histogram for total private memory footprint. (Closed)

Created:
3 years, 7 months ago by erikchen
Modified:
3 years, 6 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org, Primiano Tucci (use gerrit)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a histogram for total private memory footprint. Also update tests to check for private memory footprint on Windows, which is now implemented. BUG= Review-Url: https://codereview.chromium.org/2904703002 Cr-Commit-Position: refs/heads/master@{#474931} Committed: https://chromium.googlesource.com/chromium/src/+/018be5c3de6e08af6132ef9efce403f38c881ac3

Patch Set 1 #

Patch Set 2 : Update tests to check private memory footprint on Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M chrome/browser/metrics/process_memory_metrics_emitter.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc View 1 2 chunks +4 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
erikchen
rkaplow: Please review.
3 years, 7 months ago (2017-05-24 01:03:25 UTC) #4
rkaplow
lgtm
3 years, 6 months ago (2017-05-24 17:35:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904703002/1
3 years, 6 months ago (2017-05-25 19:50:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904703002/20001
3 years, 6 months ago (2017-05-25 19:56:54 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/303376)
3 years, 6 months ago (2017-05-25 23:50:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904703002/20001
3 years, 6 months ago (2017-05-26 01:36:53 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 05:53:36 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/018be5c3de6e08af6132ef9efce4...

Powered by Google App Engine
This is Rietveld 408576698