Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1890)

Unified Diff: chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc

Issue 2904703002: Add a histogram for total private memory footprint. (Closed)
Patch Set: Update tests to check private memory footprint on Windows. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/process_memory_metrics_emitter.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
diff --git a/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc b/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
index 3f7515246b622ee403a1250c2b985b1d6fbae925..7c320b587b9912a7be1a8c337bc8fa6a9c037de4 100644
--- a/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
+++ b/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
@@ -86,19 +86,12 @@ void CheckMemoryMetric(const std::string& name,
void CheckAllMemoryMetrics(const base::HistogramTester& histogram_tester,
int count) {
-#if (defined(OS_MACOSX) && !defined(OS_IOS)) || defined(OS_LINUX) || \
- defined(OS_ANDROID)
- bool private_footprint_implemented = true;
-#else
- bool private_footprint_implemented = false;
-#endif
-
CheckMemoryMetric("Memory.Experimental.Browser2.Malloc", histogram_tester,
count, true);
CheckMemoryMetric("Memory.Experimental.Browser2.Resident", histogram_tester,
count, true);
CheckMemoryMetric("Memory.Experimental.Browser2.PrivateMemoryFootprint",
- histogram_tester, count, private_footprint_implemented);
+ histogram_tester, count, true);
CheckMemoryMetric("Memory.Experimental.Renderer2.Malloc", histogram_tester,
count, true);
CheckMemoryMetric("Memory.Experimental.Renderer2.Resident", histogram_tester,
@@ -110,7 +103,9 @@ void CheckAllMemoryMetrics(const base::HistogramTester& histogram_tester,
CheckMemoryMetric("Memory.Experimental.Renderer2.V8", histogram_tester, count,
true);
CheckMemoryMetric("Memory.Experimental.Renderer2.PrivateMemoryFootprint",
- histogram_tester, count, private_footprint_implemented);
+ histogram_tester, count, true);
+ CheckMemoryMetric("Memory.Experimental.Total2.PrivateMemoryFootprint",
+ histogram_tester, count, true);
}
} // namespace
« no previous file with comments | « chrome/browser/metrics/process_memory_metrics_emitter.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698