Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2903003002:
Remove final from RtcEventLogNullImpl (Closed)
|
Created:
3 years, 6 months ago by perkj_webrtc Modified:
3 years, 6 months ago Reviewers:
terelius CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove final from RtcEventLogNullImpl
The reason is that there might be implementations that do not want to implement all methods.
To allow easier modification of the RtcEventLog interface, allow these implementation to inherit the RtcEventLogNullImpl implementation.
BUG=none
Review-Url: https://codereview.webrtc.org/2903003002
Cr-Commit-Position: refs/heads/master@{#18298}
Committed: https://chromium.googlesource.com/external/webrtc/+/33bb86d5a1ec5a4aafeaea0788242bb51189d031
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by perkj@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
perkj@webrtc.org changed reviewers: + terelius@webrtc.org
Please?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17387)
lgtm
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17392)
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17479)
Description was changed from ========== Remove final from RtcEventLogNullImpl The reason is that there might be implementations that do not want to implement all methods. To allow easier modification of the RtcEventLog interface, allow these implementation to inherit the RtcEventLogNullImpl implementation. ========== to ========== Remove final from RtcEventLogNullImpl The reason is that there might be implementations that do not want to implement all methods. To allow easier modification of the RtcEventLog interface, allow these implementation to inherit the RtcEventLogNullImpl implementation. BUG=none ==========
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496050178258640, "parent_rev":
"5682240a15be75e7ff5030fb0d0c463da0c50d81", "commit_rev":
"33bb86d5a1ec5a4aafeaea0788242bb51189d031"}
Message was sent while issue was closed.
Description was changed from ========== Remove final from RtcEventLogNullImpl The reason is that there might be implementations that do not want to implement all methods. To allow easier modification of the RtcEventLog interface, allow these implementation to inherit the RtcEventLogNullImpl implementation. BUG=none ========== to ========== Remove final from RtcEventLogNullImpl The reason is that there might be implementations that do not want to implement all methods. To allow easier modification of the RtcEventLog interface, allow these implementation to inherit the RtcEventLogNullImpl implementation. BUG=none Review-Url: https://codereview.webrtc.org/2903003002 Cr-Commit-Position: refs/heads/master@{#18298} Committed: https://chromium.googlesource.com/external/webrtc/+/33bb86d5a1ec5a4aafeaea078... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/33bb86d5a1ec5a4aafeaea078... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
