Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 2903003002: Remove final from RtcEventLogNullImpl (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 // The order of the events in the EventStream is implementation defined. 181 // The order of the events in the EventStream is implementation defined.
182 // The current implementation writes a LOG_START event, then the old 182 // The current implementation writes a LOG_START event, then the old
183 // configurations, then the remaining events in timestamp order and finally 183 // configurations, then the remaining events in timestamp order and finally
184 // a LOG_END event. However, this might change without further notice. 184 // a LOG_END event. However, this might change without further notice.
185 // TODO(terelius): Change result type to a vector? 185 // TODO(terelius): Change result type to a vector?
186 static bool ParseRtcEventLog(const std::string& file_name, 186 static bool ParseRtcEventLog(const std::string& file_name,
187 rtclog::EventStream* result); 187 rtclog::EventStream* result);
188 }; 188 };
189 189
190 // No-op implementation is used if flag is not set, or in tests. 190 // No-op implementation is used if flag is not set, or in tests.
191 class RtcEventLogNullImpl final : public RtcEventLog { 191 class RtcEventLogNullImpl : public RtcEventLog {
192 public: 192 public:
193 bool StartLogging(const std::string& file_name, 193 bool StartLogging(const std::string& file_name,
194 int64_t max_size_bytes) override { 194 int64_t max_size_bytes) override {
195 return false; 195 return false;
196 } 196 }
197 bool StartLogging(rtc::PlatformFile platform_file, 197 bool StartLogging(rtc::PlatformFile platform_file,
198 int64_t max_size_bytes) override; 198 int64_t max_size_bytes) override;
199 void StopLogging() override {} 199 void StopLogging() override {}
200 void LogVideoReceiveStreamConfig( 200 void LogVideoReceiveStreamConfig(
201 const rtclog::StreamConfig& config) override {} 201 const rtclog::StreamConfig& config) override {}
(...skipping 27 matching lines...) Expand all
229 int min_probes, 229 int min_probes,
230 int min_bytes) override{}; 230 int min_bytes) override{};
231 void LogProbeResultSuccess(int id, int bitrate_bps) override{}; 231 void LogProbeResultSuccess(int id, int bitrate_bps) override{};
232 void LogProbeResultFailure(int id, 232 void LogProbeResultFailure(int id,
233 ProbeFailureReason failure_reason) override{}; 233 ProbeFailureReason failure_reason) override{};
234 }; 234 };
235 235
236 } // namespace webrtc 236 } // namespace webrtc
237 237
238 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ 238 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698