Ensure string data is kept alive as long as there are CSSVariableData tokens pointing to it

Ensure string data is kept alive as long as there are CSSVariableData tokens pointing to it

This change is part of animating registered custom properties.
Animated CSSVariableData objects won't have the same
ownership guarantees as ones owned by CSSValues.

This change removes the assumption that the tokens spliced into a
CSSVariableData during var() resolution will have their backing strings
kept alive somewhere else and instead keeps all necessary string handles
alongside the tokens.

This patch introduces no changes in behaviour.

BUG=671904
Review-Url: https://codereview.chromium.org/2901213005
Cr-Commit-Position: refs/heads/master@{#474970}
Committed: https://chromium.googlesource.com/chromium/src/+/ee6e4b4ccc884117e4e7069b69d953306be9d7b1

[alancutter (OOO until 2018), 2017-05-25 07:43:17]

Description was changed from

==========
Ensure string data is kept alive as long as there are CSSVariableData tokens
pointing to it

BUG=671904
==========

to

==========
Ensure string data is kept alive as long as there are CSSVariableData tokens
pointing to it

This change is part of animating registered custom properties. Intermediate
CSSVariableData don't have the same ownership guarantees as data owned by
CSSValues.

This change removes the assumption that the tokens spliced into a
CSSVariableData during var() resolution will have their backing strings
kept alive somewhere else and instead stores all necessary string handles
along side the tokens.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-05-25 07:43:18]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[alancutter (OOO until 2018), 2017-05-25 07:44:29]

Description was changed from

==========
Ensure string data is kept alive as long as there are CSSVariableData tokens
pointing to it

This change is part of animating registered custom properties. Intermediate
CSSVariableData don't have the same ownership guarantees as data owned by
CSSValues.

This change removes the assumption that the tokens spliced into a
CSSVariableData during var() resolution will have their backing strings
kept alive somewhere else and instead stores all necessary string handles
along side the tokens.

BUG=671904
==========

to

==========
Ensure string data is kept alive as long as there are CSSVariableData tokens
pointing to it

This change is part of animating registered custom properties.
Animated CSSVariableData objects won't have the same
ownership guarantees as ones owned by CSSValues.

This change removes the assumption that the tokens spliced into a
CSSVariableData during var() resolution will have their backing strings
kept alive somewhere else and instead keeps all necessary string handles
alongside the tokens.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-05-26 01:18:56]

Description was changed from

==========
Ensure string data is kept alive as long as there are CSSVariableData tokens
pointing to it

This change is part of animating registered custom properties.
Animated CSSVariableData objects won't have the same
ownership guarantees as ones owned by CSSValues.

This change removes the assumption that the tokens spliced into a
CSSVariableData during var() resolution will have their backing strings
kept alive somewhere else and instead keeps all necessary string handles
alongside the tokens.

BUG=671904
==========

to

==========
Ensure string data is kept alive as long as there are CSSVariableData tokens
pointing to it

This change is part of animating registered custom properties.
Animated CSSVariableData objects won't have the same
ownership guarantees as ones owned by CSSValues.

This change removes the assumption that the tokens spliced into a
CSSVariableData during var() resolution will have their backing strings
kept alive somewhere else and instead keeps all necessary string handles
alongside the tokens.

This patch introduces no changes in behaviour.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-05-26 06:17:08]

alancutter@chromium.org changed reviewers:
+ shend@chromium.org
- timloh@chromium.org

[alancutter (OOO until 2018), 2017-05-26 06:17:09]

Redirecting review as timloh no longer works on style code.

[shend, 2017-05-26 06:28:54]

lgtm

[alancutter (OOO until 2018), 2017-05-26 06:41:17]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-05-26 06:41:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 08:53:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495780877821240,
"parent_rev": "fe4711c9fcc64f843d139b74889febf8834d4d0c", "commit_rev":
"ee6e4b4ccc884117e4e7069b69d953306be9d7b1"}

[commit-bot: I haz the power, 2017-05-26 08:54:05]

Description was changed from

==========
Ensure string data is kept alive as long as there are CSSVariableData tokens
pointing to it

This change is part of animating registered custom properties.
Animated CSSVariableData objects won't have the same
ownership guarantees as ones owned by CSSValues.

This change removes the assumption that the tokens spliced into a
CSSVariableData during var() resolution will have their backing strings
kept alive somewhere else and instead keeps all necessary string handles
alongside the tokens.

This patch introduces no changes in behaviour.

BUG=671904
==========

to

==========
Ensure string data is kept alive as long as there are CSSVariableData tokens
pointing to it

This change is part of animating registered custom properties.
Animated CSSVariableData objects won't have the same
ownership guarantees as ones owned by CSSValues.

This change removes the assumption that the tokens spliced into a
CSSVariableData during var() resolution will have their backing strings
kept alive somewhere else and instead keeps all necessary string handles
alongside the tokens.

This patch introduces no changes in behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2901213005
Cr-Commit-Position: refs/heads/master@{#474970}
Committed:
https://chromium.googlesource.com/chromium/src/+/ee6e4b4ccc884117e4e7069b69d9...
==========

[commit-bot: I haz the power, 2017-05-26 08:54:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ee6e4b4ccc884117e4e7069b69d9...