third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h - Issue 2901213005: Ensure string data is kept alive as long as there are CSSVariableData tokens pointing to it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

Issue 2901213005: Ensure string data is kept alive as long as there are CSSVariableData tokens pointing to it (Closed)

Patch Set: comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

diff --git a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

index bbf7e94951995be9afe2879eedf544ae8b1b398b..fe5baa0205196c778417ff90776ca5613ed38f5a 100644

--- a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

+++ b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

@@ -58,20 +58,25 @@ class CSSVariableResolver {

bool ResolveTokenRange(CSSParserTokenRange,

bool disallow_animation_tainted,

Vector<CSSParserToken>& result,

+ Vector<String>& result_backing_strings,

bool& result_is_animation_tainted);

// Resolves the fallback (if present) of a var() reference, starting from the

// comma.

bool ResolveFallback(CSSParserTokenRange,

bool disallow_animation_tainted,

Vector<CSSParserToken>& result,

+ Vector<String>& result_backing_strings,

bool& result_is_animation_tainted);

// Resolves the contents of a var() reference.

bool ResolveVariableReference(CSSParserTokenRange,

bool disallow_animation_tainted,

Vector<CSSParserToken>& result,

+ Vector<String>& result_backing_strings,

bool& result_is_animation_tainted);

// Consumes and resolves an @apply rule.

- void ResolveApplyAtRule(CSSParserTokenRange&, Vector<CSSParserToken>& result);

+ void ResolveApplyAtRule(CSSParserTokenRange&,

+ Vector<CSSParserToken>& result,

+ Vector<String>& result_backing_strings);

// These return null if the custom property is invalid.