Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 2900633003: Make TextEmphasisMark an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextEmphasisMark an enum class. This patch makes TextEmphasisMark an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2900633003 Cr-Commit-Position: refs/heads/master@{#474944} Committed: https://chromium.googlesource.com/chromium/src/+/e96260c1487284932117eb66862f7b47efb61ef5

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Messages

Total messages: 29 (25 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-24 03:10:18 UTC) #2
rune
lgtm
3 years, 7 months ago (2017-05-24 06:25:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900633003/80001
3 years, 7 months ago (2017-05-26 06:35:05 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 06:40:18 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e96260c1487284932117eb66862f...

Powered by Google App Engine
This is Rietveld 408576698