Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2900633003: Make TextEmphasisMark an enum class. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index d1ae76b8c36b9bac726137b03b193fe202ec8a51..d157de68f064bf644b2579366d7c1150dc655d26 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -1626,24 +1626,24 @@ template <>
inline CSSIdentifierValue::CSSIdentifierValue(TextEmphasisMark mark)
: CSSValue(kIdentifierClass) {
switch (mark) {
- case kTextEmphasisMarkDot:
+ case TextEmphasisMark::kDot:
value_id_ = CSSValueDot;
break;
- case kTextEmphasisMarkCircle:
+ case TextEmphasisMark::kCircle:
value_id_ = CSSValueCircle;
break;
- case kTextEmphasisMarkDoubleCircle:
+ case TextEmphasisMark::kDoubleCircle:
value_id_ = CSSValueDoubleCircle;
break;
- case kTextEmphasisMarkTriangle:
+ case TextEmphasisMark::kTriangle:
value_id_ = CSSValueTriangle;
break;
- case kTextEmphasisMarkSesame:
+ case TextEmphasisMark::kSesame:
value_id_ = CSSValueSesame;
break;
- case kTextEmphasisMarkNone:
- case kTextEmphasisMarkAuto:
- case kTextEmphasisMarkCustom:
+ case TextEmphasisMark::kNone:
+ case TextEmphasisMark::kAuto:
+ case TextEmphasisMark::kCustom:
NOTREACHED();
value_id_ = CSSValueNone;
break;
@@ -1654,23 +1654,23 @@ template <>
inline TextEmphasisMark CSSIdentifierValue::ConvertTo() const {
switch (value_id_) {
case CSSValueNone:
- return kTextEmphasisMarkNone;
+ return TextEmphasisMark::kNone;
case CSSValueDot:
- return kTextEmphasisMarkDot;
+ return TextEmphasisMark::kDot;
case CSSValueCircle:
- return kTextEmphasisMarkCircle;
+ return TextEmphasisMark::kCircle;
case CSSValueDoubleCircle:
- return kTextEmphasisMarkDoubleCircle;
+ return TextEmphasisMark::kDoubleCircle;
case CSSValueTriangle:
- return kTextEmphasisMarkTriangle;
+ return TextEmphasisMark::kTriangle;
case CSSValueSesame:
- return kTextEmphasisMarkSesame;
+ return TextEmphasisMark::kSesame;
default:
break;
}
NOTREACHED();
- return kTextEmphasisMarkNone;
+ return TextEmphasisMark::kNone;
}
template <>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698