Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2899973004: Revert of Remove unecessary non fatal error statement that very often is printed in the PSNR or SSIM metric n… (Closed)

Created:
3 years, 7 months ago by janssonWebRTC
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove unecessary non fatal error statement that very often is printed in the PSNR or SSIM metric n… (patchset #1 id:1 of https://codereview.webrtc.org/2901793002/ ) Reason for revert: Looks like we need the return there after all: derefence error in: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fclient.webrtc.perf%2FAndroid64_Tests__L_Nexus9_%2F2967%2F%2B%2Frecipes%2Fsteps%2Fvideo_quality_loopback_test%2F0%2Fstdout Original issue's description: > Remove unecessary non fatal error statement that very often is printed in the PSNR or SSIM metric numbered list > > BUG=webrtc:7698 > NOTRY=TRUE > > Review-Url: https://codereview.webrtc.org/2901793002 > Cr-Commit-Position: refs/heads/master@{#18234} > Committed: https://chromium.googlesource.com/external/webrtc/+/18d023f9ee6201be20e4bc68e3fc070404a8edbc TBR=kjellander@webrtc.org,oprypin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7698 Review-Url: https://codereview.webrtc.org/2899973004 Cr-Commit-Position: refs/heads/master@{#18239} Committed: https://chromium.googlesource.com/external/webrtc/+/cc8b14b1ec418979393f101df648a876cc8ecaf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/tools/frame_analyzer/video_quality_analysis.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
janssonWebRTC
3 years, 7 months ago (2017-05-23 15:30:57 UTC) #2
Created Revert of Remove unecessary non fatal error statement that very often is
printed in the PSNR or SSIM metric n…

Powered by Google App Engine
This is Rietveld 408576698