Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 2901793002: Remove unecessary non fatal error statement that very often is printed in the PSNR or SSIM metric n… (Closed)

Created:
3 years, 7 months ago by janssonWebRTC
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unecessary non fatal error statement that very often is printed in the PSNR or SSIM metric numbered list BUG=webrtc:7698 NOTRY=TRUE Review-Url: https://codereview.webrtc.org/2901793002 Cr-Commit-Position: refs/heads/master@{#18234} Committed: https://chromium.googlesource.com/external/webrtc/+/18d023f9ee6201be20e4bc68e3fc070404a8edbc

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into removeUnecessaryError #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/tools/frame_analyzer/video_quality_analysis.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
janssonWebRTC
3 years, 7 months ago (2017-05-23 12:37:07 UTC) #4
kjellander_webrtc
lgtm
3 years, 7 months ago (2017-05-23 13:04:25 UTC) #5
kjellander_webrtc
On 2017/05/23 13:04:25, kjellander_webrtc wrote: > lgtm Although, if it actually is often printed it ...
3 years, 7 months ago (2017-05-23 13:05:27 UTC) #6
oprypin_webrtc
lgtm
3 years, 7 months ago (2017-05-23 13:06:34 UTC) #7
janssonWebRTC
On 2017/05/23 13:05:27, kjellander_webrtc wrote: > On 2017/05/23 13:04:25, kjellander_webrtc wrote: > > lgtm > ...
3 years, 7 months ago (2017-05-23 14:24:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2901793002/1
3 years, 7 months ago (2017-05-23 14:24:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/18d023f9ee6201be20e4bc68e3fc070404a8edbc
3 years, 7 months ago (2017-05-23 14:26:46 UTC) #13
janssonWebRTC
3 years, 7 months ago (2017-05-23 15:30:56 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2899973004/ by jansson@webrtc.org.

The reason for reverting is: Looks like we need the return there after all:
derefence error in:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fclient.webrtc.perf%2FAnd....

Powered by Google App Engine
This is Rietveld 408576698