Issue 2898813002: Update Packet::GetHeader() to copy playout_delay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2898813002: Update Packet::GetHeader() to copy playout_delay (Closed)

Created:
3 years, 7 months ago by Sergey Ulanov

Modified:
3 years, 7 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org

Target Ref:
refs/branch-heads/59

Project:
webrtc

Visibility:
Public.

Update Packet::GetHeader() to copy playout_delay Packet::GetHeader() wasn't copying playout_delay. As result playout_delay was ignored when flexfec is enabled. Patch by Rob McCool <rmccool@google.com>; BUG=webrtc:7590 Review-Url: https://codereview.webrtc.org/2899553003 Cr-Commit-Position: refs/heads/master@{#18218} (cherry picked from commit b2c001a79542050d69fa916199f51d5d98626f21) BUG=chromium:722490 Review-Url: https://codereview.webrtc.org/2898813002 . Cr-Commit-Position: refs/branch-heads/59@{#13} Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/ab7f856fa72a531fa5b9bdafbcc83de21888589e

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webrtc/modules/rtp_rtcp/source/rtp_packet.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Sergey Ulanov

3 years, 7 months ago (2017-05-22 19:48:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ab7f856fa72a531fa5b9bdafbcc83de21888589e.