Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2899553003: Update Packet::GetHeader() to copy playout_delay (Closed)

Created:
3 years, 7 months ago by Sergey Ulanov
Modified:
3 years, 7 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman, philipel
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update Packet::GetHeader() to copy playout_delay Packet::GetHeader() wasn't copying playout_delay. As result playout_delay was ignored when flexfec is enabled. Patch by Rob McCool <rmccool@google.com>; BUG=webrtc:7590 Review-Url: https://codereview.webrtc.org/2899553003 Cr-Commit-Position: refs/heads/master@{#18218} Committed: https://chromium.googlesource.com/external/webrtc/+/b2c001a79542050d69fa916199f51d5d98626f21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Sergey Ulanov
3 years, 7 months ago (2017-05-20 19:48:56 UTC) #2
danilchap
lgtm
3 years, 7 months ago (2017-05-20 20:53:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2899553003/1
3 years, 7 months ago (2017-05-20 20:54:55 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 21:16:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b2c001a79542050d69fa91619...

Powered by Google App Engine
This is Rietveld 408576698