Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2894673004: increase bitrate precision of the network tester. (Closed)

Created:
3 years, 7 months ago by tschumi
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

increase bitrate precision of the network tester. Recreation of issue 2851463002. BUG=webrtc:7426 Review-Url: https://codereview.webrtc.org/2894673004 Cr-Commit-Position: refs/heads/master@{#18219} Committed: https://chromium.googlesource.com/external/webrtc/+/d4aebb0d1f066bef77ce2c490fb1337ed316a875

Patch Set 1 #

Patch Set 2 : Fix for bug in SendData. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M webrtc/tools/network_tester/packet_sender.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M webrtc/tools/network_tester/test_controller.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
tschumi
Because my webrtc mail address was changed, I had to upload the fix in a ...
3 years, 7 months ago (2017-05-19 08:38:36 UTC) #7
nisse-webrtc
Still lgtm.
3 years, 7 months ago (2017-05-19 08:43:31 UTC) #8
stefan-webrtc
lgtm
3 years, 7 months ago (2017-05-19 16:06:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2894673004/2
3 years, 7 months ago (2017-05-22 06:41:57 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 07:04:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:2) as
https://chromium.googlesource.com/external/webrtc/+/d4aebb0d1f066bef77ce2c490...

Powered by Google App Engine
This is Rietveld 408576698