Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: webrtc/tools/network_tester/test_controller.cc

Issue 2894673004: increase bitrate precision of the network tester. (Closed)
Patch Set: Fix for bug in SendData. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/tools/network_tester/packet_sender.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/network_tester/test_controller.cc
diff --git a/webrtc/tools/network_tester/test_controller.cc b/webrtc/tools/network_tester/test_controller.cc
index 51deac7bb726968dee0a7d6228c7c5c1949751d3..40af6437cb7eed8b6dc8f3d887d3cbf422479c48 100644
--- a/webrtc/tools/network_tester/test_controller.cc
+++ b/webrtc/tools/network_tester/test_controller.cc
@@ -22,8 +22,8 @@ TestController::TestController(int min_port,
local_test_done_(false),
remote_test_done_(false) {
RTC_DCHECK_RUN_ON(&test_controller_thread_checker_);
- send_data_.fill(42);
packet_sender_checker_.Detach();
+ send_data_.fill(42);
auto socket =
std::unique_ptr<rtc::AsyncPacketSocket>(socket_factory_.CreateUdpSocket(
rtc::SocketAddress(rtc::GetAnyIP(AF_INET), 0), min_port, max_port));
@@ -53,10 +53,11 @@ void TestController::SendData(const NetworkTesterPacket& packet,
// Can be call from packet_sender or from test_controller thread.
size_t packet_size = packet.ByteSize();
send_data_[0] = packet_size;
+ packet_size++;
packet.SerializeToArray(&send_data_[1], std::numeric_limits<char>::max());
if (data_size && *data_size > packet_size)
packet_size = *data_size;
- udp_transport_->SendPacket(send_data_.data(), packet_size + 1,
+ udp_transport_->SendPacket(send_data_.data(), packet_size,
rtc::PacketOptions(), 0);
}
« no previous file with comments | « webrtc/tools/network_tester/packet_sender.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698