Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2894583002: Delete Filesystem::IterateDirectory and Filesystem::OpenFile. (Closed)

Created:
3 years, 7 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete Filesystem::IterateDirectory and Filesystem::OpenFile. BUG=webrtc:7345, webrtc:6424 Review-Url: https://codereview.webrtc.org/2894583002 Cr-Commit-Position: refs/heads/master@{#18344} Committed: https://chromium.googlesource.com/external/webrtc/+/210832696f339f93cb7b955a428ef86efe329be7

Patch Set 1 #

Patch Set 2 : Check stream.Open return value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -103 lines) Patch
M webrtc/base/filerotatingstream_unittest.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download
M webrtc/base/fileutils.h View 2 chunks +0 lines, -20 lines 0 comments Download
M webrtc/base/fileutils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/fileutils_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M webrtc/base/unixfilesystem.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/base/unixfilesystem.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/base/win32filesystem.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/base/win32filesystem.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
nisse-webrtc
PTAL. These methods appear unused.
3 years, 7 months ago (2017-05-18 13:46:18 UTC) #2
Taylor Brandstetter
lgtm, though it appears OpenFile is still used internally.
3 years, 7 months ago (2017-05-18 21:26:07 UTC) #3
nisse-webrtc
On 2017/05/18 21:26:07, Taylor Brandstetter wrote: > lgtm, though it appears OpenFile is still used ...
3 years, 7 months ago (2017-05-19 06:26:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2894583002/20001
3 years, 6 months ago (2017-05-31 08:48:51 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 09:07:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/210832696f339f93cb7b955a4...

Powered by Google App Engine
This is Rietveld 408576698