Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: webrtc/base/fileutils.h

Issue 2894583002: Delete Filesystem::IterateDirectory and Filesystem::OpenFile. (Closed)
Patch Set: Check stream.Open return value. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/filerotatingstream_unittest.cc ('k') | webrtc/base/fileutils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/fileutils.h
diff --git a/webrtc/base/fileutils.h b/webrtc/base/fileutils.h
index cddf2dc367f45a719add0b1a71ea497769e64eaa..f2669281bd3add54ddda3e0d7f70f389d78d7cc9 100644
--- a/webrtc/base/fileutils.h
+++ b/webrtc/base/fileutils.h
@@ -80,17 +80,6 @@ class FilesystemInterface {
public:
virtual ~FilesystemInterface() {}
- // Returns a DirectoryIterator for a given pathname.
- // TODO: Do fancy abstracted stuff
- virtual DirectoryIterator* IterateDirectory();
-
- // Opens a file. Returns an open StreamInterface if function succeeds.
- // Otherwise, returns null.
- // TODO: Add an error param to indicate failure reason, similar to
- // FileStream::Open
- virtual FileStream *OpenFile(const Pathname &filename,
- const std::string &mode) = 0;
-
// This will attempt to delete the path located at filename.
// It DCHECKs and returns false if the path points to a folder or a
// non-existent file.
@@ -176,19 +165,10 @@ class Filesystem {
return cur;
}
- static DirectoryIterator *IterateDirectory() {
- return EnsureDefaultFilesystem()->IterateDirectory();
- }
-
static bool CreateFolder(const Pathname &pathname) {
return EnsureDefaultFilesystem()->CreateFolder(pathname);
}
- static FileStream *OpenFile(const Pathname &filename,
- const std::string &mode) {
- return EnsureDefaultFilesystem()->OpenFile(filename, mode);
- }
-
static bool DeleteFile(const Pathname &filename) {
return EnsureDefaultFilesystem()->DeleteFile(filename);
}
« no previous file with comments | « webrtc/base/filerotatingstream_unittest.cc ('k') | webrtc/base/fileutils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698