Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2891923002: Delete Filesystem::CreateFolder. (Closed)

Created:
3 years, 7 months ago by nisse-webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc, noahric-google
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete Filesystem::CreateFolder. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2891923002 Cr-Commit-Position: refs/heads/master@{#19766} Committed: https://chromium.googlesource.com/external/webrtc/+/0677904e1b916594ab695a2282619cb3f207f03a

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
M webrtc/rtc_base/fileutils.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M webrtc/rtc_base/logging_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/rtc_base/unixfilesystem.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/rtc_base/unixfilesystem.cc View 1 1 chunk +0 lines, -33 lines 0 comments Download
M webrtc/rtc_base/win32filesystem.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/rtc_base/win32filesystem.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
nisse-webrtc
PTAL. More apparently unneeded code.
3 years, 7 months ago (2017-05-18 14:23:45 UTC) #2
Taylor Brandstetter
lgtm assuming the downstream code that's using "CreateFolder" can switch to something else.
3 years, 7 months ago (2017-05-18 23:57:23 UTC) #3
nisse-webrtc
Hi, since the downstream code no longer used CreateFolder, I'll try to get this landed, ...
3 years, 3 months ago (2017-09-11 08:48:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2891923002/20001
3 years, 3 months ago (2017-09-11 09:33:43 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-09-11 09:36:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0677904e1b916594ab695a228...

Powered by Google App Engine
This is Rietveld 408576698