In CreateFolder, delete code to recursively create parent directories.

In CreateFolder, delete code to recursively create parent directories.

BUG=webrtc:6424

[nisse-webrtc, 2017-08-30 13:56:42]

nisse@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, noahric@google.com

[nisse-webrtc, 2017-08-30 13:56:43]

Can we delete the "mkdir -p"-like recursive creation of directories?

Noah, you're owner of the only downstream code using this function which I'm
aware of. Making sure that recursive creation is not needed should make it
easier to replace.

[Taylor Brandstetter, 2017-08-30 22:49:35]

lgtm pending response from Noah.

[noahric, 2017-08-31 06:54:06]

On 2017/08/30 22:49:35, Taylor Brandstetter wrote:
> lgtm pending response from Noah.

Let me double check; I think we do use it, but I can change it so we don't.

[nisse-webrtc, 2017-09-06 09:23:10]

On 2017/08/31 06:54:06, noahric wrote:
> On 2017/08/30 22:49:35, Taylor Brandstetter wrote:
> > lgtm pending response from Noah.
> 
> Let me double check; I think we do use it, but I can change it so we don't.

Ping?

Note this cl doesn't delete CreateFolder, it only changes it to require that the
parent directory already exists. The idea is that if we know that doesn't break
the downstream application, we'll have a better idea of what's needed to replace
CreateFolder.

[noahric, 2017-09-06 19:16:33]

Description was changed from

==========
In CreateFolder, delete code to recursively create parent directories.

BUG=webrtc:6424
==========

to

==========
In CreateFolder, delete code to recursively create parent directories.

BUG=webrtc:6424
==========

[noahric, 2017-09-06 19:16:33]

noahric@chromium.org changed reviewers:
+ noahric@chromium.org
- noahric@google.com

[noahric, 2017-09-06 19:17:21]

On 2017/09/06 09:23:10, nisse-webrtc wrote:
> On 2017/08/31 06:54:06, noahric wrote:
> > On 2017/08/30 22:49:35, Taylor Brandstetter wrote:
> > > lgtm pending response from Noah.
> > 
> > Let me double check; I think we do use it, but I can change it so we don't.
> 
> Ping?
> 
> Note this cl doesn't delete CreateFolder, it only changes it to require that
the
> parent directory already exists. The idea is that if we know that doesn't
break
> the downstream application, we'll have a better idea of what's needed to
replace
> CreateFolder.

Sorry, I didn't get to it in stockholm last week and haven't gotten back to
normal work until today.

I have a CL that should obviate our need for it, just wanted to test it a bit to
make sure it's working correctly.

[noahric, 2017-09-07 00:57:08]

On 2017/09/06 19:17:21, noahric wrote:
> On 2017/09/06 09:23:10, nisse-webrtc wrote:
> > On 2017/08/31 06:54:06, noahric wrote:
> > > On 2017/08/30 22:49:35, Taylor Brandstetter wrote:
> > > > lgtm pending response from Noah.
> > > 
> > > Let me double check; I think we do use it, but I can change it so we
don't.
> > 
> > Ping?
> > 
> > Note this cl doesn't delete CreateFolder, it only changes it to require that
> the
> > parent directory already exists. The idea is that if we know that doesn't
> break
> > the downstream application, we'll have a better idea of what's needed to
> replace
> > CreateFolder.
> 
> Sorry, I didn't get to it in stockholm last week and haven't gotten back to
> normal work until today.
> 
> I have a CL that should obviate our need for it, just wanted to test it a bit
to
> make sure it's working correctly.

CL works fine, just waiting for a review. Should be submitted tomorrow kirkland
time, so another two days for you, sorry :(

[nisse-webrtc, 2017-09-07 06:38:28]

On 2017/09/07 00:57:08, noahric wrote:
> On 2017/09/06 19:17:21, noahric wrote:
> > On 2017/09/06 09:23:10, nisse-webrtc wrote:
> > > On 2017/08/31 06:54:06, noahric wrote:
> > > > On 2017/08/30 22:49:35, Taylor Brandstetter wrote:
> > > > > lgtm pending response from Noah.
> > > > 
> > > > Let me double check; I think we do use it, but I can change it so we
> don't.
> > > 
> > > Ping?
> > > 
> > > Note this cl doesn't delete CreateFolder, it only changes it to require
that
> > the
> > > parent directory already exists. The idea is that if we know that doesn't
> > break
> > > the downstream application, we'll have a better idea of what's needed to
> > replace
> > > CreateFolder.
> > 
> > Sorry, I didn't get to it in stockholm last week and haven't gotten back to
> > normal work until today.
> > 
> > I have a CL that should obviate our need for it, just wanted to test it a
bit
> to
> > make sure it's working correctly.
> 
> CL works fine, just waiting for a review. Should be submitted tomorrow
kirkland
> time, so another two days for you, sorry :(

It's not urgent, I'm happy you're looking into it.

[nisse-webrtc, 2017-09-13 07:01:54]

The other cl to delete CreateFolder has now landed, making this cl obsolete.
Closing.