Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2889183002: Reland of Removes usage of native base::android::GetApplicationContext() (Closed)

Created:
3 years, 7 months ago by sakal
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of moves usage of native base::android::GetApplicationContext() (patchset #1 id:1 of https://codereview.webrtc.org/2894593002/ ) Reason for revert: Fix issue. Original issue's description: > Revert of Removes usage of native base::android::GetApplicationContext() (patchset #6 id:120001 of https://codereview.webrtc.org/2888093004/ ) > > Reason for revert: > Breaks bot on chromium.webrtc.fyi. > > Original issue's description: > > Removes usage of native base::android::GetApplicationContext() > > > > BUG=webrtc:7665 > > > > Review-Url: https://codereview.webrtc.org/2888093004 > > Cr-Commit-Position: refs/heads/master@{#18195} > > Committed: https://chromium.googlesource.com/external/webrtc/+/bc83e2ee696ca3672b8cebd658672e95eec4e465 > > TBR=magjed@webrtc.org,henrika@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7665 > > Review-Url: https://codereview.webrtc.org/2894593002 > Cr-Commit-Position: refs/heads/master@{#18196} > Committed: https://chromium.googlesource.com/external/webrtc/+/40d224814a68bf90e5ab847df0105de2a89006e9 BUG=webrtc:7665 Review-Url: https://codereview.webrtc.org/2889183002 Cr-Commit-Position: refs/heads/master@{#18235} Committed: https://chromium.googlesource.com/external/webrtc/+/7855fff5bf045e7975fca78bce6d85d0add61c0f

Patch Set 1 : Disable both. #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase? #

Patch Set 4 : Remove unneeded include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -54 lines) Patch
M webrtc/modules/audio_device/android/audio_manager.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_record_jni.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_track_jni.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/android/ensure_initialized.cc View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java View 5 chunks +10 lines, -7 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/utility/include/jvm_android.h View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/utility/source/jvm_android.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M webrtc/pc/test/androidtestinitializer.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java View 3 chunks +10 lines, -3 lines 0 comments Download
M webrtc/sdk/android/src/jni/peerconnection_jni.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A webrtc/test/android/AndroidManifest.xml View 1 chunk +46 lines, -0 lines 0 comments Download
A webrtc/test/android/org/webrtc/native_test/RTCNativeUnitTest.java View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/test/android/org/webrtc/native_test/RTCNativeUnitTestActivity.java View 1 chunk +34 lines, -0 lines 0 comments Download
M webrtc/webrtc.gni View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (24 generated)
sakal
Created Reland of moves usage of native base::android::GetApplicationContext()
3 years, 7 months ago (2017-05-18 13:45:56 UTC) #1
henrika_webrtc
lgtm
3 years, 7 months ago (2017-05-18 14:30:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2889183002/390001
3 years, 7 months ago (2017-05-23 12:52:47 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2889183002/410001
3 years, 7 months ago (2017-05-23 13:04:30 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:410001) as https://chromium.googlesource.com/external/webrtc/+/7855fff5bf045e7975fca78bce6d85d0add61c0f
3 years, 7 months ago (2017-05-23 14:34:23 UTC) #28
lliuu
3 years, 7 months ago (2017-05-24 21:36:11 UTC) #29
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:410001) has been created in
https://codereview.webrtc.org/2902263002/ by lliuu@webrtc.org.

The reason for reverting is: Breaking internal project.

Powered by Google App Engine
This is Rietveld 408576698