Removes usage of native base::android::GetApplicationContext()

Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665
Review-Url: https://codereview.webrtc.org/2888093004
Cr-Commit-Position: refs/heads/master@{#18195}
Committed: https://chromium.googlesource.com/external/webrtc/+/bc83e2ee696ca3672b8cebd658672e95eec4e465

[sakal, 2017-05-18 07:50:18]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 07:50:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2017-05-18 07:52:45]

Description was changed from

==========
Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665

patch from issue 2887723002 at patchset 40001
(http://crrev.com/2887723002#ps40001)
==========

to

==========
Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665

patch from issue 2887723002 at patchset 40001
(http://crrev.com/2887723002#ps40001)
==========

[sakal, 2017-05-18 07:52:45]

sakal@webrtc.org changed reviewers:
+ henrika@webrtc.org, magjed@webrtc.org

[sakal, 2017-05-18 07:54:48]

PTAL

[henrika_webrtc, 2017-05-18 08:03:10]

Thanks. Looks great.

Some comments.

https://codereview.webrtc.org/2888093004/diff/20001/webrtc/base/java/src/org/...
File webrtc/base/java/src/org/webrtc/ContextUtils.java (right):

https://codereview.webrtc.org/2888093004/diff/20001/webrtc/base/java/src/org/...
webrtc/base/java/src/org/webrtc/ContextUtils.java:16: * Class for storing the
application context and retrieving it in a static context.
I think you should add some comments on where this class comes from (or the name
at least). And perhaps add some more comments from that class.

https://codereview.webrtc.org/2888093004/diff/20001/webrtc/base/java/src/org/...
webrtc/base/java/src/org/webrtc/ContextUtils.java:21: public static void
initialize(Context applicationContext) {
The corresponding method in Chrome calls:

throw new RuntimeException("Attempting to set multiple global application
contexts.");

Perhaps we should to the same.

https://codereview.webrtc.org/2888093004/diff/40001/webrtc/sdk/android/api/or...
File webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java (right):

https://codereview.webrtc.org/2888093004/diff/40001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java:62:
nativeInitializeAndroidGlobals(context, videoHwAcceleration);
Should we not try to remove this context argument as well?

https://codereview.webrtc.org/2888093004/diff/40001/webrtc/sdk/android/src/jn...
File webrtc/sdk/android/src/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/2888093004/diff/40001/webrtc/sdk/android/src/jn...
webrtc/sdk/android/src/jni/peerconnection_jni.cc:1142: jobject context,
Can we now remove the context parameter?

[sakal, 2017-05-18 08:15:29]

Patchset #4 (id:60001) has been deleted

[sakal, 2017-05-18 08:16:57]

https://codereview.webrtc.org/2888093004/diff/20001/webrtc/base/java/src/org/...
File webrtc/base/java/src/org/webrtc/ContextUtils.java (right):

https://codereview.webrtc.org/2888093004/diff/20001/webrtc/base/java/src/org/...
webrtc/base/java/src/org/webrtc/ContextUtils.java:16: * Class for storing the
application context and retrieving it in a static context.
On 2017/05/18 08:03:09, henrika_webrtc wrote:
> I think you should add some comments on where this class comes from (or the
name
> at least). And perhaps add some more comments from that class.

Done.

https://codereview.webrtc.org/2888093004/diff/20001/webrtc/base/java/src/org/...
webrtc/base/java/src/org/webrtc/ContextUtils.java:21: public static void
initialize(Context applicationContext) {
On 2017/05/18 08:03:09, henrika_webrtc wrote:
> The corresponding method in Chrome calls:
> 
> throw new RuntimeException("Attempting to set multiple global application
> contexts.");
> 
> Perhaps we should to the same.

Done.

https://codereview.webrtc.org/2888093004/diff/40001/webrtc/sdk/android/api/or...
File webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java (right):

https://codereview.webrtc.org/2888093004/diff/40001/webrtc/sdk/android/api/or...
webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java:62:
nativeInitializeAndroidGlobals(context, videoHwAcceleration);
On 2017/05/18 08:03:09, henrika_webrtc wrote:
> Should we not try to remove this context argument as well?

We probably should but I think we should do that in a future CL after the roll
is unblocked.

https://codereview.webrtc.org/2888093004/diff/40001/webrtc/sdk/android/src/jn...
File webrtc/sdk/android/src/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/2888093004/diff/40001/webrtc/sdk/android/src/jn...
webrtc/sdk/android/src/jni/peerconnection_jni.cc:1142: jobject context,
On 2017/05/18 08:03:09, henrika_webrtc wrote:
> Can we now remove the context parameter?

See above.

[henrika_webrtc, 2017-05-18 08:20:52]

lgtm

[sakal, 2017-05-18 08:22:54]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 08:23:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-18 09:01:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 09:01:14]

Dry run: Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/24190)

[sakal, 2017-05-18 12:01:39]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 12:01:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[henrika_webrtc, 2017-05-18 12:06:29]

Great work. 

lgtm++

[commit-bot: I haz the power, 2017-05-18 12:25:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 12:25:30]

Dry run: This issue passed the CQ dry run.

[sakal, 2017-05-18 12:29:11]

Description was changed from

==========
Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665

patch from issue 2887723002 at patchset 40001
(http://crrev.com/2887723002#ps40001)
==========

to

==========
Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665
==========

[sakal, 2017-05-18 13:25:47]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2017-05-18 13:25:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-18 13:28:46]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495113947878940,
"parent_rev": "b243ee91c3b1e7cfc27f28d8ac17a7a8a9943cca", "commit_rev":
"bc83e2ee696ca3672b8cebd658672e95eec4e465"}

[commit-bot: I haz the power, 2017-05-18 13:28:51]

Description was changed from

==========
Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665
==========

to

==========
Removes usage of native base::android::GetApplicationContext()

BUG=webrtc:7665

Review-Url: https://codereview.webrtc.org/2888093004
Cr-Commit-Position: refs/heads/master@{#18195}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bc83e2ee696ca3672b8cebd65...
==========

[commit-bot: I haz the power, 2017-05-18 13:28:53]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/bc83e2ee696ca3672b8cebd65...

[sakal, 2017-05-18 13:44:04]

A revert of this CL (patchset #6 id:120001) has been created in
https://codereview.webrtc.org/2894593002/ by sakal@webrtc.org.

The reason for reverting is: Breaks bot on chromium.webrtc.fyi..