Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2886873007: Revert of Update build_ios_libs.py to new GN target names. (Closed)

Created:
3 years, 7 months ago by kthelgason
Modified:
3 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Update build_ios_libs.py to new GN target names. (patchset #1 id:1 of https://codereview.webrtc.org/2888903002/ ) Reason for revert: This depends on another CL that has been reverted. Original issue's description: > Update build_ios_libs.py to new GN target names. > > TBR=kjellander@webrtc.org > NOTRY=true > BUG=None > > Review-Url: https://codereview.webrtc.org/2888903002 > Cr-Commit-Position: refs/heads/master@{#18175} > Committed: https://chromium.googlesource.com/external/webrtc/+/c3f110a1f9c53d84c70a89af5786c9fc33a8b71d TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2886873007 Cr-Commit-Position: refs/heads/master@{#18183} Committed: https://chromium.googlesource.com/external/webrtc/+/d743c8dd6875632df90094bbb21d6b7f4e4660a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools_webrtc/ios/build_ios_libs.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
kthelgason
Created Revert of Update build_ios_libs.py to new GN target names.
3 years, 7 months ago (2017-05-17 13:52:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2886873007/1
3 years, 7 months ago (2017-05-17 13:53:01 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 13:54:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d743c8dd6875632df90094bbb...

Powered by Google App Engine
This is Rietveld 408576698