Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2888903002: Update build_ios_libs.py to new GN target names. (Closed)

Created:
3 years, 7 months ago by kthelgason
Modified:
3 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update build_ios_libs.py to new GN target names. TBR=kjellander@webrtc.org NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2888903002 Cr-Commit-Position: refs/heads/master@{#18175} Committed: https://chromium.googlesource.com/external/webrtc/+/c3f110a1f9c53d84c70a89af5786c9fc33a8b71d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools_webrtc/ios/build_ios_libs.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2888903002/1
3 years, 7 months ago (2017-05-17 11:24:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/c3f110a1f9c53d84c70a89af5786c9fc33a8b71d
3 years, 7 months ago (2017-05-17 11:26:47 UTC) #9
kthelgason
3 years, 7 months ago (2017-05-17 13:52:52 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2886873007/ by kthelgason@webrtc.org.

The reason for reverting is: This depends on another CL that has been reverted..

Powered by Google App Engine
This is Rietveld 408576698