Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2886143002: Reland of Add gerrit to cq.cfg (Closed)

Created:
3 years, 7 months ago by ehmaldonado_webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add gerrit to cq.cfg (patchset #1 id:1 of https://codereview.webrtc.org/2888113002/ ) Reason for revert: False alarm Original issue's description: > Revert of Add gerrit to cq.cfg (patchset #2 id:20001 of https://codereview.webrtc.org/2888533004/ ) > > Reason for revert: > Might have broken CQ. > > Original issue's description: > > Add gerrit to cq.cfg > > > > BUG=chromium:672378 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2888533004 > > Cr-Commit-Position: refs/heads/master@{#18177} > > Committed: https://chromium.googlesource.com/external/webrtc/+/81a28f1174e3c175f4c60040d8754ecf7e4bbb28 > > TBR=tandrii@chromium.org,kjellander@webrtc.org,tandrii@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:672378 > > Review-Url: https://codereview.webrtc.org/2888113002 > Cr-Commit-Position: refs/heads/master@{#18178} > Committed: https://chromium.googlesource.com/external/webrtc/+/b30843a2faae8975b2d9f6706f9013327b169948 TBR=tandrii@chromium.org,kjellander@webrtc.org,tandrii@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:672378 Review-Url: https://codereview.webrtc.org/2886143002 Cr-Commit-Position: refs/heads/master@{#18181} Committed: https://chromium.googlesource.com/external/webrtc/+/acb8e4171876ebcee524b34b116b11fe6f7ddcf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M infra/config/cq.cfg View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ehmaldonado_webrtc
Created Reland of Add gerrit to cq.cfg
3 years, 7 months ago (2017-05-17 12:26:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2886143002/1
3 years, 7 months ago (2017-05-17 12:26:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/acb8e4171876ebcee524b34b116b11fe6f7ddcf4
3 years, 7 months ago (2017-05-17 12:26:38 UTC) #6
kjellander_webrtc
3 years, 7 months ago (2017-05-17 13:10:55 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698