Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2888533004: Add gerrit to cq.cfg (Closed)

Created:
3 years, 7 months ago by ehmaldonado_webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add gerrit to cq.cfg BUG=chromium:672378 NOTRY=True Review-Url: https://codereview.webrtc.org/2888533004 Cr-Commit-Position: refs/heads/master@{#18177} Committed: https://chromium.googlesource.com/external/webrtc/+/81a28f1174e3c175f4c60040d8754ecf7e4bbb28

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add git_repo_url. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M infra/config/cq.cfg View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
ehmaldonado_webrtc
3 years, 7 months ago (2017-05-17 11:27:45 UTC) #2
ehmaldonado_webrtc
Like this? Am I missing something else?
3 years, 7 months ago (2017-05-17 11:28:11 UTC) #3
tandrii_google
https://codereview.webrtc.org/2888533004/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.webrtc.org/2888533004/diff/1/infra/config/cq.cfg#newcode8 infra/config/cq.cfg:8: max_commit_burst: 1 add git_url as in https://chromium.googlesource.com/v8/v8/+/master/infra/config/cq.cfg#7
3 years, 7 months ago (2017-05-17 11:31:25 UTC) #5
ehmaldonado_webrtc
On 2017/05/17 11:31:25, tandrii_google wrote: > https://codereview.webrtc.org/2888533004/diff/1/infra/config/cq.cfg > File infra/config/cq.cfg (right): > > https://codereview.webrtc.org/2888533004/diff/1/infra/config/cq.cfg#newcode8 > ...
3 years, 7 months ago (2017-05-17 11:35:51 UTC) #6
tandrii_google
lgtm
3 years, 7 months ago (2017-05-17 11:37:41 UTC) #7
kjellander_webrtc
lgtm
3 years, 7 months ago (2017-05-17 11:39:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2888533004/20001
3 years, 7 months ago (2017-05-17 11:43:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/81a28f1174e3c175f4c60040d8754ecf7e4bbb28
3 years, 7 months ago (2017-05-17 11:46:11 UTC) #14
ehmaldonado_webrtc
3 years, 7 months ago (2017-05-17 12:01:34 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2888113002/ by ehmaldonado@webrtc.org.

The reason for reverting is: Might have broken CQ..

Powered by Google App Engine
This is Rietveld 408576698