Reland of reduce dependencies on rtc::FileSystem in FileRotatingStream tests...

Reland of reduce dependencies on rtc::FileSystem in FileRotatingStream tests... (patchset #1 id:1 of https://codereview.webrtc.org/2885393002/ )

Reason for revert:
Downstream project now fixed. 

Original issue's description:
> Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests, adding helpers in webrtc::test:: (patchset #7 id:120001 of https://codereview.webrtc.org/2872283002/ )
> 
> Reason for revert:
> Fails to compile successfully. 
> 
> 
> Original issue's description:
> > Reduce dependencies on rtc::FileSystem in FileRotatingStream tests.
> > 
> > Use webrtc::test::OutputPath instead of Filesystem::GetAppTempFolder.
> > Added functions RemoveFile and RemoveDir in the webrtc::test namespace,
> > to replace use of Filesystem::DeleteFolderAndContents.
> > 
> > This makes Filesystem::DeleteFolderAndContents unused, to be deleted
> > together with related code in a followup cl.
> > 
> > BUG=webrtc:7345
> > 
> > Review-Url: https://codereview.webrtc.org/2872283002
> > Cr-Commit-Position: refs/heads/master@{#18173}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/dd7b5f32b59d9def668b9e9487589a572f20f6e0
> 
> TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,nisse@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7345
> 
> Review-Url: https://codereview.webrtc.org/2885393002
> Cr-Commit-Position: refs/heads/master@{#18180}
> Committed: https://chromium.googlesource.com/external/webrtc/+/deaa33d2f59783e849ddc01428be807d92431983

TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,ehmaldonado@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7345
Review-Url: https://codereview.webrtc.org/2885413002
Cr-Commit-Position: refs/heads/master@{#18193}
Committed: https://chromium.googlesource.com/external/webrtc/+/57efb038bb4537b17bcbd9a7d1324752849c5432

[nisse-webrtc, 2017-05-17 14:09:08]

Created Reland of duce dependencies on rtc::FileSystem in FileRotatingStream
tests...

[nisse-webrtc, 2017-05-17 14:10:04]

Description was changed from

==========
Reland of duce dependencies on rtc::FileSystem in FileRotatingStream tests...
(patchset #1 id:1 of https://codereview.webrtc.org/2885393002/ )

Reason for revert:
Downstream project now fixed. 

Original issue's description:
> Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests,
adding helpers in webrtc::test:: (patchset #7 id:120001 of
https://codereview.webrtc.org/2872283002/ )
> 
> Reason for revert:
> Fails to compile successfully. 
> 
> 
> Original issue's description:
> > Reduce dependencies on rtc::FileSystem in FileRotatingStream tests.
> > 
> > Use webrtc::test::OutputPath instead of Filesystem::GetAppTempFolder.
> > Added functions RemoveFile and RemoveDir in the webrtc::test namespace,
> > to replace use of Filesystem::DeleteFolderAndContents.
> > 
> > This makes Filesystem::DeleteFolderAndContents unused, to be deleted
> > together with related code in a followup cl.
> > 
> > BUG=webrtc:7345
> > 
> > Review-Url: https://codereview.webrtc.org/2872283002
> > Cr-Commit-Position: refs/heads/master@{#18173}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/dd7b5f32b59d9def668b9e948...
> 
>
TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,nisse@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7345
> 
> Review-Url: https://codereview.webrtc.org/2885393002
> Cr-Commit-Position: refs/heads/master@{#18180}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/deaa33d2f59783e849ddc0142...

TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,ehmaldonado@w...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7345
==========

to

==========
Reland of reduce dependencies on rtc::FileSystem in FileRotatingStream tests...
(patchset #1 id:1 of https://codereview.webrtc.org/2885393002/ )

Reason for revert:
Downstream project now fixed. 

Original issue's description:
> Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests,
adding helpers in webrtc::test:: (patchset #7 id:120001 of
https://codereview.webrtc.org/2872283002/ )
> 
> Reason for revert:
> Fails to compile successfully. 
> 
> 
> Original issue's description:
> > Reduce dependencies on rtc::FileSystem in FileRotatingStream tests.
> > 
> > Use webrtc::test::OutputPath instead of Filesystem::GetAppTempFolder.
> > Added functions RemoveFile and RemoveDir in the webrtc::test namespace,
> > to replace use of Filesystem::DeleteFolderAndContents.
> > 
> > This makes Filesystem::DeleteFolderAndContents unused, to be deleted
> > together with related code in a followup cl.
> > 
> > BUG=webrtc:7345
> > 
> > Review-Url: https://codereview.webrtc.org/2872283002
> > Cr-Commit-Position: refs/heads/master@{#18173}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/dd7b5f32b59d9def668b9e948...
> 
>
TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,nisse@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7345
> 
> Review-Url: https://codereview.webrtc.org/2885393002
> Cr-Commit-Position: refs/heads/master@{#18180}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/deaa33d2f59783e849ddc0142...

TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,ehmaldonado@w...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7345
==========

[nisse-webrtc, 2017-05-17 14:10:38]

On 2017/05/17 14:09:08, nisse-webrtc wrote:
> Created Reland of duce dependencies on rtc::FileSystem in FileRotatingStream
> tests...

What tests needed before relanding?

[ehmaldonado_webrtc, 2017-05-17 14:19:30]

ehmaldonado@webrtc.org changed reviewers:
+ charujain@webrtc.org

[ehmaldonado_webrtc, 2017-05-17 14:19:42]

On 2017/05/17 14:10:38, nisse-webrtc wrote:
> On 2017/05/17 14:09:08, nisse-webrtc wrote:
> > Created Reland of duce dependencies on rtc::FileSystem in FileRotatingStream
> > tests...
> 
> What tests needed before relanding?

+charu

[charujain1, 2017-05-17 14:22:54]

On 2017/05/17 14:19:42, ehmaldonado_webrtc wrote:
> On 2017/05/17 14:10:38, nisse-webrtc wrote:
> > On 2017/05/17 14:09:08, nisse-webrtc wrote:
> > > Created Reland of duce dependencies on rtc::FileSystem in
FileRotatingStream
> > > tests...
> > 
> > What tests needed before relanding?
> 
> +charu

Internal trybot linux_internal?

[nisse-webrtc, 2017-05-17 14:32:20]

On 2017/05/17 14:22:54, charujain1 wrote:
> On 2017/05/17 14:19:42, ehmaldonado_webrtc wrote:
> > On 2017/05/17 14:10:38, nisse-webrtc wrote:
> > > On 2017/05/17 14:09:08, nisse-webrtc wrote:
> > > > Created Reland of duce dependencies on rtc::FileSystem in
> FileRotatingStream
> > > > tests...
> > > 
> > > What tests needed before relanding?
> > 
> > +charu
> 
> Internal trybot linux_internal?

Started that and a few other trybots.

[nisse-webrtc, 2017-05-18 06:28:54]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 06:28:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-18 06:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 06:54:19]

Dry run: This issue passed the CQ dry run.

[nisse-webrtc, 2017-05-18 10:53:44]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-05-18 10:53:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-18 10:55:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495104824356310, "parent_rev":
"8838f13072c57d25b3bd456be20fff410a29c291", "commit_rev":
"57efb038bb4537b17bcbd9a7d1324752849c5432"}

[commit-bot: I haz the power, 2017-05-18 10:56:04]

Description was changed from

==========
Reland of reduce dependencies on rtc::FileSystem in FileRotatingStream tests...
(patchset #1 id:1 of https://codereview.webrtc.org/2885393002/ )

Reason for revert:
Downstream project now fixed. 

Original issue's description:
> Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests,
adding helpers in webrtc::test:: (patchset #7 id:120001 of
https://codereview.webrtc.org/2872283002/ )
> 
> Reason for revert:
> Fails to compile successfully. 
> 
> 
> Original issue's description:
> > Reduce dependencies on rtc::FileSystem in FileRotatingStream tests.
> > 
> > Use webrtc::test::OutputPath instead of Filesystem::GetAppTempFolder.
> > Added functions RemoveFile and RemoveDir in the webrtc::test namespace,
> > to replace use of Filesystem::DeleteFolderAndContents.
> > 
> > This makes Filesystem::DeleteFolderAndContents unused, to be deleted
> > together with related code in a followup cl.
> > 
> > BUG=webrtc:7345
> > 
> > Review-Url: https://codereview.webrtc.org/2872283002
> > Cr-Commit-Position: refs/heads/master@{#18173}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/dd7b5f32b59d9def668b9e948...
> 
>
TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,nisse@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7345
> 
> Review-Url: https://codereview.webrtc.org/2885393002
> Cr-Commit-Position: refs/heads/master@{#18180}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/deaa33d2f59783e849ddc0142...

TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,ehmaldonado@w...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7345
==========

to

==========
Reland of reduce dependencies on rtc::FileSystem in FileRotatingStream tests...
(patchset #1 id:1 of https://codereview.webrtc.org/2885393002/ )

Reason for revert:
Downstream project now fixed. 

Original issue's description:
> Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests,
adding helpers in webrtc::test:: (patchset #7 id:120001 of
https://codereview.webrtc.org/2872283002/ )
> 
> Reason for revert:
> Fails to compile successfully. 
> 
> 
> Original issue's description:
> > Reduce dependencies on rtc::FileSystem in FileRotatingStream tests.
> > 
> > Use webrtc::test::OutputPath instead of Filesystem::GetAppTempFolder.
> > Added functions RemoveFile and RemoveDir in the webrtc::test namespace,
> > to replace use of Filesystem::DeleteFolderAndContents.
> > 
> > This makes Filesystem::DeleteFolderAndContents unused, to be deleted
> > together with related code in a followup cl.
> > 
> > BUG=webrtc:7345
> > 
> > Review-Url: https://codereview.webrtc.org/2872283002
> > Cr-Commit-Position: refs/heads/master@{#18173}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/dd7b5f32b59d9def668b9e948...
> 
>
TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,nisse@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7345
> 
> Review-Url: https://codereview.webrtc.org/2885393002
> Cr-Commit-Position: refs/heads/master@{#18180}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/deaa33d2f59783e849ddc0142...

TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,ehmaldonado@w...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7345

Review-Url: https://codereview.webrtc.org/2885413002
Cr-Commit-Position: refs/heads/master@{#18193}
Committed:
https://chromium.googlesource.com/external/webrtc/+/57efb038bb4537b17bcbd9a7d...
==========

[commit-bot: I haz the power, 2017-05-18 10:56:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/57efb038bb4537b17bcbd9a7d...