Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2885393002: Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests... (Closed)

Created:
3 years, 7 months ago by ehmaldonado_webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc, tkchin_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests, adding helpers in webrtc::test:: (patchset #7 id:120001 of https://codereview.webrtc.org/2872283002/ ) Reason for revert: Fails to compile successfully. Original issue's description: > Reduce dependencies on rtc::FileSystem in FileRotatingStream tests. > > Use webrtc::test::OutputPath instead of Filesystem::GetAppTempFolder. > Added functions RemoveFile and RemoveDir in the webrtc::test namespace, > to replace use of Filesystem::DeleteFolderAndContents. > > This makes Filesystem::DeleteFolderAndContents unused, to be deleted > together with related code in a followup cl. > > BUG=webrtc:7345 > > Review-Url: https://codereview.webrtc.org/2872283002 > Cr-Commit-Position: refs/heads/master@{#18173} > Committed: https://chromium.googlesource.com/external/webrtc/+/dd7b5f32b59d9def668b9e9487589a572f20f6e0 TBR=pthatcher@webrtc.org,kjellander@webrtc.org,tommi@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7345 Review-Url: https://codereview.webrtc.org/2885393002 Cr-Commit-Position: refs/heads/master@{#18180} Committed: https://chromium.googlesource.com/external/webrtc/+/deaa33d2f59783e849ddc01428be807d92431983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -55 lines) Patch
M webrtc/base/filerotatingstream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/filerotatingstream_unittest.cc View 3 chunks +20 lines, -32 lines 0 comments Download
M webrtc/test/testsupport/fileutils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/test/testsupport/fileutils.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ehmaldonado_webrtc
Created Revert of Reduce dependencies on rtc::FileSystem in FileRotatingStream tests, adding helpers in webrtc::test::
3 years, 7 months ago (2017-05-17 12:22:01 UTC) #2
kjellander_webrtc
If we cannot provide a link to where it failed to compile, we should at ...
3 years, 7 months ago (2017-05-17 13:13:35 UTC) #4
nisse-webrtc
3 years, 7 months ago (2017-05-17 14:09:07 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2885413002/ by nisse@webrtc.org.

The reason for reverting is: Downstream project now fixed. .

Powered by Google App Engine
This is Rietveld 408576698