Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2885163003: Allow constructing an EglBase from an existing shared EGLContext. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, cyr_google.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow constructing an EglBase from an existing shared EGLContext. BUG=None Review-Url: https://codereview.webrtc.org/2885163003 Cr-Commit-Position: refs/heads/master@{#18266} Committed: https://chromium.googlesource.com/external/webrtc/+/a615e17ec0ad7739b367034473ab3312299e70da

Patch Set 1 #

Patch Set 2 : Use name "sharedContext", as it's used elsewhere. #

Total comments: 3

Patch Set 3 : shared -> shader #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M webrtc/sdk/android/api/org/webrtc/EglBase.java View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Taylor Brandstetter
PTAL. CCed cyr@ who was requesting this.
3 years, 7 months ago (2017-05-17 17:25:05 UTC) #2
magjed_webrtc
lgtm https://codereview.webrtc.org/2885163003/diff/20001/webrtc/sdk/android/api/org/webrtc/EglBase.java File webrtc/sdk/android/api/org/webrtc/EglBase.java (right): https://codereview.webrtc.org/2885163003/diff/20001/webrtc/sdk/android/api/org/webrtc/EglBase.java#newcode120 webrtc/sdk/android/api/org/webrtc/EglBase.java:120: * and shader context. nit: shared, not shader. ...
3 years, 7 months ago (2017-05-25 14:25:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2885163003/40001
3 years, 7 months ago (2017-05-25 16:53:54 UTC) #6
Taylor Brandstetter
https://codereview.webrtc.org/2885163003/diff/20001/webrtc/sdk/android/api/org/webrtc/EglBase.java File webrtc/sdk/android/api/org/webrtc/EglBase.java (right): https://codereview.webrtc.org/2885163003/diff/20001/webrtc/sdk/android/api/org/webrtc/EglBase.java#newcode120 webrtc/sdk/android/api/org/webrtc/EglBase.java:120: * and shader context. On 2017/05/25 14:25:19, magjed_webrtc wrote: ...
3 years, 7 months ago (2017-05-25 16:53:57 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 17:11:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/a615e17ec0ad7739b36703447...

Powered by Google App Engine
This is Rietveld 408576698