Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2883313003: Remove VirtualSocketServer's dependency on PhysicalSocketServer. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VirtualSocketServer's dependency on PhysicalSocketServer. The only thing the physical socket server was used for was "Wait"/"WakeUp", but it could be replaced by a simple rtc::Event. So, removing this dependency makes things less confusing; the fact that VirtualSocketServer takes a PhysicalSocketServer may lead someone to think it uses real sockets internally, when it doesn't. BUG=None Review-Url: https://codereview.webrtc.org/2883313003 Cr-Commit-Position: refs/heads/master@{#18172} Committed: https://chromium.googlesource.com/external/webrtc/+/98e186c71c10fa7d221fa82391865be1adfdff72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -148 lines) Patch
M webrtc/base/asynctcpsocket_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/base/nat_unittest.cc View 3 chunks +10 lines, -16 lines 0 comments Download
M webrtc/base/natsocketfactory.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/ssladapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/virtualsocket_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/base/virtualsocketserver.h View 3 chunks +4 lines, -7 lines 0 comments Download
M webrtc/base/virtualsocketserver.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M webrtc/ortc/ortcfactory_integrationtest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/ortc/ortcfactory_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/p2p/base/asyncstuntcpsocket_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 5 chunks +2 lines, -8 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/p2p/base/portallocator_unittest.cc View 3 chunks +1 line, -5 lines 0 comments Download
M webrtc/p2p/base/relayport_unittest.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M webrtc/p2p/base/relayserver_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/p2p/base/stunport_unittest.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M webrtc/p2p/base/stunserver_unittest.cc View 3 chunks +1 line, -7 lines 0 comments Download
M webrtc/p2p/base/tcpport_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M webrtc/p2p/base/turnserver_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M webrtc/p2p/base/udptransport_unittest.cc View 3 chunks +1 line, -5 lines 0 comments Download
M webrtc/p2p/client/basicportallocator_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/pc/peerconnection_integrationtest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 3 chunks +1 line, -5 lines 0 comments Download
M webrtc/pc/rtcstats_integrationtest.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M webrtc/pc/webrtcsession_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Taylor Brandstetter
3 years, 7 months ago (2017-05-16 17:39:59 UTC) #4
pthatcher1
lgtm Wow, that's nice.
3 years, 7 months ago (2017-05-17 00:30:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2883313003/1
3 years, 7 months ago (2017-05-17 00:57:10 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 01:00:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/98e186c71c10fa7d221fa8239...

Powered by Google App Engine
This is Rietveld 408576698