Remove VirtualSocketServer's dependency on PhysicalSocketServer.

webrtc/ortc/ortcfactory_unittest.cc

 /*
  *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <memory>
 
 #include "webrtc/base/fakenetwork.h"
 #include "webrtc/base/gunit.h"
-#include "webrtc/base/physicalsocketserver.h"
 #include "webrtc/base/virtualsocketserver.h"
 #include "webrtc/media/base/fakemediaengine.h"
 #include "webrtc/ortc/ortcfactory.h"
 #include "webrtc/ortc/testrtpparameters.h"
 #include "webrtc/p2p/base/fakepackettransport.h"
 
 namespace webrtc {
 
 // This test uses a virtual network and fake media engine, in order to test the
 // OrtcFactory at only an API level. Any end-to-end test should go in
 // ortcfactory_integrationtest.cc instead.
 class OrtcFactoryTest : public testing::Test {
  public:
   OrtcFactoryTest()
-      : virtual_socket_server_(&physical_socket_server_),
-        thread_(&virtual_socket_server_),
+      : thread_(&virtual_socket_server_),
         fake_packet_transport_("fake transport") {
     ortc_factory_ =
         OrtcFactory::Create(nullptr, nullptr, &fake_network_manager_, nullptr,
                             nullptr,
                             std::unique_ptr<cricket::MediaEngineInterface>(
                                 new cricket::FakeMediaEngine()))
             .MoveValue();
   }
 
  protected:
   // Uses a single pre-made FakePacketTransport, so shouldn't be called twice in
   // the same test.
   std::unique_ptr<RtpTransportInterface>
   CreateRtpTransportWithFakePacketTransport() {
     return ortc_factory_
         ->CreateRtpTransport(MakeRtcpMuxParameters(), &fake_packet_transport_,
                              nullptr, nullptr)
         .MoveValue();
   }
 
-  rtc::PhysicalSocketServer physical_socket_server_;
   rtc::VirtualSocketServer virtual_socket_server_;
   rtc::AutoSocketServerThread thread_;
   rtc::FakeNetworkManager fake_network_manager_;
   rtc::FakePacketTransport fake_packet_transport_;
   std::unique_ptr<OrtcFactoryInterface> ortc_factory_;
 };
 
 TEST_F(OrtcFactoryTest, CanCreateMultipleRtpTransportControllers) {
   auto controller_result1 = ortc_factory_->CreateRtpTransportController();
   EXPECT_TRUE(controller_result1.ok());
@@ skipping 186 matching lines @@
 TEST_F(OrtcFactoryTest, CreateSendersOrReceieversWithNullTransport) {
   auto sender_result =
       ortc_factory_->CreateRtpSender(cricket::MEDIA_TYPE_AUDIO, nullptr);
   EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, sender_result.error().type());
   auto receiver_result =
       ortc_factory_->CreateRtpReceiver(cricket::MEDIA_TYPE_AUDIO, nullptr);
   EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, receiver_result.error().type());
 }
 
 }  // namespace webrtc