Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2882183004: Removed implicit divisions in the residual echo detector (Closed)

Created:
3 years, 7 months ago by peah-webrtc
Modified:
3 years, 7 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed implicit divisions in the residual echo detector This CL changes the updating of a loop index from using the modulus operator to using a conditional, avoiding the divisions done in the modulus operator which had a measurable impact on mpbile platforms. Additionally, there is a similar removal of another modulus operator, but the impact of that should be negligible. BUG=webrtc:7666 Review-Url: https://codereview.webrtc.org/2882183004 Cr-Commit-Position: refs/heads/master@{#18168} Committed: https://chromium.googlesource.com/external/webrtc/+/94f6fa0526c2bbb5c953efad752a0d6658f2c81e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M webrtc/modules/audio_processing/residual_echo_detector.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
peah-webrtc
ivoc@: Could you PTAL on this CL. It aims at reducing the APM complexity on ...
3 years, 7 months ago (2017-05-16 13:22:57 UTC) #4
ivoc
LGTM.
3 years, 7 months ago (2017-05-16 13:28:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2882183004/1
3 years, 7 months ago (2017-05-16 14:05:56 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 14:25:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/94f6fa0526c2bbb5c953efad7...

Powered by Google App Engine
This is Rietveld 408576698